client profile and UI changes #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Get Recommendations without profile builder 2. Batch job fix for "Email;Sms" 3. UI enhancements for refer "Mobile Phone Carrier"
| @@ -262,7 +262,9 @@ public with sharing class EmailService { | |||
| } | |||
| // update any tasks that have been completed | |||
| if (!tasksToUpdate.isEmpty()) { | |||
| update Security.stripInaccessible(AccessType.UPDATABLE, tasksToUpdate).getRecords(); | |||
| map<id,Task> tskMap = new map<id,Task>(); | |||
There was a problem hiding this comment.
What is the need of Map<Id, Task> in this use case? The list variable can be directly used instead of adding to a map.
There was a problem hiding this comment.
List will contain a duplicate id and running to the "System.ListException: Duplicate id in list error"
https://salesforcescool.blogspot.com/2018/11/systemlistexception-duplicate-id-in.html?m=1
| // hard filters are currently Age | ||
| public static list<Service__c> primaryQuery(Client_Profile__c client, String filterList) { | ||
| if(Schema.Client_Profile__c.SObjectType == Id.valueOf(client.id).getSobjectType()) { | ||
| //decimal age = calculateAge(client.Date_Of_Birth__c); |
There was a problem hiding this comment.
Remove commented code.
anilpilakavv
suggested changes
Jul 13, 2021
Removing the commented line
anilpilakavv
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical Changes
Changes
Issues Closed