Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loadout colors #174

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Loadout colors #174

merged 3 commits into from
Sep 9, 2019

Conversation

Longi94
Copy link
Contributor

@Longi94 Longi94 commented Sep 7, 2019

No description provided.

@todo
Copy link

todo bot commented Sep 7, 2019

handle 'user_color_old', looks like an ID like primary and accent colors

# TODO handle 'user_color_old', looks like an ID like primary and accent colors
if 'user_color_new' in attribute['value']:
# rgb integer, 0xAARRGGBB, banners and avatar borders have different default values
paint[item_name] = attribute['value']['user_color_new']
self.paint.append({
'car': paint.get('body', None),


This comment was generated by todo based on a TODO comment in 65a302a in #174. cc @SaltieRL.

@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #174 into master will decrease coverage by 0.01%.
The diff coverage is 86.2%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   88.89%   88.87%   -0.02%     
==========================================
  Files          89       89              
  Lines        3880     3909      +29     
  Branches      635      646      +11     
==========================================
+ Hits         3449     3474      +25     
  Misses        346      346              
- Partials       85       89       +4

@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #174 into master will decrease coverage by 0.05%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   88.89%   88.83%   -0.06%     
==========================================
  Files          89       89              
  Lines        3880     3915      +35     
  Branches      635      647      +12     
==========================================
+ Hits         3449     3478      +29     
- Misses        346      347       +1     
- Partials       85       90       +5

@todo
Copy link

todo bot commented Sep 8, 2019

handle 'user_color_old', looks like an ID like primary and accent colors

# TODO handle 'user_color_old', looks like an ID like primary and accent colors
if 'user_color_new' in attribute['value']:
# rgb integer, 0xAARRGGBB, banners and avatar borders have different default values
user_color[item_name] = attribute['value']['user_color_new']
self.paint.append({
'car': paint.get('body', None),


This comment was generated by todo based on a TODO comment in f39636d in #174. cc @SaltieRL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants