Issue #14 - Send capabilities in initialize #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
14-initialize-capabilities
branch
from
f3a2ca3 to
4a2e0e2
Compare
ayuckhulk
requested changes
Apr 4, 2019
| @@ -279,6 +276,14 @@ typedef std::function<HRESULT( | |||
| const json &arguments, | |||
| json &body)> CommandCallback; | |||
|
|
|||
| void VSCodeProtocol::addCapabilities(json &capabilities) | |||
There was a problem hiding this comment.
How about renaming it to AddCapabilitiesTo ?
- Capital
Afollows the naming convention for other class methods Toindicates that the this methods adds capabilities to passed argument instead of adding capabilities to class instance
Signed-off-by: Mickael Istria <mistria@redhat.com>
mickaelistria
force-pushed
the
14-initialize-capabilities
branch
from
4a2e0e2 to
80ed6c8
Compare
|
I just updated the commit as you suggested. |
ayuckhulk
approved these changes
Apr 4, 2019
|
@mickaelistria Thank you for your contribution! |
|
Awesome, thanks! And I see it's already available in https://github.com/Samsung/netcoredbg/releases . That's really nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mickael Istria mistria@redhat.com