feat: updated dockerfile and revived docker functionality #304
Conversation
|
@Bhavya-55 is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe Dockerfile has been updated to improve performance and efficiency. Changes include switching to a lighter base image ( Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
the
title needs formatting
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Bhavya-55! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Dockerfile (1 hunks)
Additional comments not posted (4)
Dockerfile (4)
1-1: Switch tonode:alpinebase image to reduce container size.
3-8: Ensure all necessary configuration files are copied correctly.
11-11: Switch fromnpm installtoyarn installfor dependency management.
16-16: Switch fromnpm run buildtoyarn buildto align with the use of Yarn.
Dockerfile
Outdated
| # Command to run on container start | ||
| CMD ["yarn", "dev"] | ||
| CMD ["yarn","dev"] |
There was a problem hiding this comment.
Tip
Codebase Verification
Using yarn dev in the Dockerfile, which executes next dev, is inappropriate for production environments as it starts the server in development mode. This mode is not optimized for performance and security, which are critical in production. It is recommended to use yarn start for production environments, which runs the server in production mode.
- Change the Dockerfile command from
CMD ["yarn","dev"]toCMD ["yarn","start"]to align with production requirements.
Analysis chain
Using yarn dev as the startup command. Ensure this aligns with production requirements, as dev typically starts a development server.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if `yarn dev` is appropriate for production or if it should be `yarn start`.
# Test: Search for yarn scripts definitions in package.json. Expect: `dev` script suitable for development only.
cat package.json | jq '.scripts.dev'
Length of output: 47
Can you tell me where I can provide the Resend api key in this dockerfile from the .env assuming when someone pull this image, he/she has that? Also few things to do:
|
Sanchitbajaj02
changed the title
github-actions
bot
removed
the
title needs formatting
Sanchitbajaj02
added
🪲 bug
|
|
||
| # Install app dependencies | ||
| COPY ["package.json", "yarn.lock*", "./"] | ||
| #RUN npm install | ||
| RUN yarn install |
There was a problem hiding this comment.
How would yarn be installed into the image?
There was a problem hiding this comment.
@Sanchitbajaj02 yarn can be installed like npm. Both are packages . Yarn is faster that why I did yarn install
There was a problem hiding this comment.
How does image be created from source of app? I think there might be a script for it.
(Note: I don't know docker much so I am mentioning this from my theoretical knowledge of it)
|
Hi @Bhavya-55 |
|
@Sanchitbajaj02 I will make the relevant changes and all that needs to be done by today. By the end of day I will raise pr . |
|
Hi @Bhavya-55 |
|
@Sanchitbajaj02 We copy the specific configuration files and package.json first to ensure they are cached by Docker's layer caching mechanism. It is structured in a such a way to minimize redundant files |
Thanks for reviewing changes but pr is already updated , what needs to be done further let me know . I have already pushed the recent changes .. |
Related Issue
fixes #297
Description
reduced size and also updated dockerfile and revived functionality.
There is missing API key when trying to collect page data for the /api/send once that configure this dockerfile will run absolutely fine . pls if anyone into backend check that
Screenshots
Summary by CodeRabbit
Summary by CodeRabbit