-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added workflow as per issue #342 #346
feat: added workflow as per issue #342 #346
Conversation
@Asymtode712 is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe new Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant Developer as Developer
participant GitHub as GitHub
participant Workflow as close-on-merge.yml
participant Issue as GitHub Issue
Developer->>GitHub: Merge Pull Request
GitHub->>Workflow: Trigger close-on-merge.yml
Workflow->>GitHub: Extract linked issue numbers from PR body
Workflow->>Issue: Close linked issues
Workflow->>Issue: Add comment indicating closure by PR
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Asymtode712! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/close-on-merge.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/close-on-merge.yml (1)
1-30
: Ensure the workflow meets the PR objectives and follows best practices.The workflow is well-structured and aligns with the PR objectives to automatically comment on and close issues when a PR is merged. It uses standard GitHub Actions features and follows best practices for workflow design.
@Sanchitbajaj02 please review and merge this PR Also, please add labels and assign me this PR |
@Sanchitbajaj02 please add 'gssoc' label it was removed by the bot |
Related Issue
fixes: #342
Description
This feature aims to solve the problem of poor communication and lack of acknowledgment when issues are closed. By automatically commenting on closed issues, it ensures that contributors are informed about the closure and are thanked for their efforts. This helps maintain a positive and engaging community atmosphere, encouraging continued contributions and fostering good relationships between maintainers and contributors.
Summary by CodeRabbit