Preview of function or mixin code #124

Closed
ArekBartnik opened this Issue Jul 20, 2014 · 11 comments

Comments

Projects
None yet
4 participants
@ArekBartnik

It would be nice to see a whole code of mixin or function after clicking the box with { ... }.

I know there is a "Fount at" section but I thinking about SassDoc as place for learning sass code in project so it would be easier without going between browser and editor.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 20, 2014

Member

It might be interesting to do something like this. Unfortunately as of today I'm not sure @FWeinb's parser is able to grab the whole content of an item.

Member

HugoGiraudel commented Jul 20, 2014

It might be interesting to do something like this. Unfortunately as of today I'm not sure @FWeinb's parser is able to grab the whole content of an item.

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Jul 20, 2014

Member

Sure that could be added

Member

FWeinb commented Jul 20, 2014

Sure that could be added

@HugoGiraudel HugoGiraudel added the 1.3 label Jul 20, 2014

@HugoGiraudel HugoGiraudel added this to the 1.3 milestone Jul 20, 2014

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 20, 2014

Member

Great news! Tagging this for 1.3 then.

Member

HugoGiraudel commented Jul 20, 2014

Great news! Tagging this for 1.3 then.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
Member

valeriangalliat commented Jul 25, 2014

+1

@HugoGiraudel HugoGiraudel removed the 1.3 label Jul 30, 2014

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Aug 13, 2014

Member

Fixed in scss-comment-parser@0.2.2. The context object of type function and mixin includes the key code which holdes the complete source code.

So accessing the code is just item.context.code

Member

FWeinb commented Aug 13, 2014

Fixed in scss-comment-parser@0.2.2. The context object of type function and mixin includes the key code which holdes the complete source code.

So accessing the code is just item.context.code

@FWeinb FWeinb closed this Aug 13, 2014

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Aug 13, 2014

Member

Tests needs to be updated. Will do know.

Member

FWeinb commented Aug 13, 2014

Tests needs to be updated. Will do know.

@FWeinb FWeinb reopened this Aug 13, 2014

FWeinb added a commit that referenced this issue Aug 13, 2014

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Aug 13, 2014

Member

Done in #165

Member

FWeinb commented Aug 13, 2014

Done in #165

@FWeinb FWeinb closed this Aug 13, 2014

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Aug 13, 2014

Member

From my early observations:

  1. Line breaks are not all preserved.
@function is-valid-length($value) { @return (type-of($value) == "number" and not unitless($value)) or index("auto" "initial" "inherit" 0, $value); }
  1. It breaks at first }.
@function z($layer) { @if not map-has-key($z-indexes, $layer) {
    @warn "No z-index found for `#{$layer }
Member

HugoGiraudel commented Aug 13, 2014

From my early observations:

  1. Line breaks are not all preserved.
@function is-valid-length($value) { @return (type-of($value) == "number" and not unitless($value)) or index("auto" "initial" "inherit" 0, $value); }
  1. It breaks at first }.
@function z($layer) { @if not map-has-key($z-indexes, $layer) {
    @warn "No z-index found for `#{$layer }

@HugoGiraudel HugoGiraudel reopened this Aug 15, 2014

@FWeinb FWeinb referenced this issue in SassDoc/scss-comment-parser Aug 16, 2014

Closed

Add code to the `context` #11

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Aug 16, 2014

Member

Ugh. I didn't think about that. We need to update to parser. See SassDoc/scss-comment-parser#11

Member

FWeinb commented Aug 16, 2014

Ugh. I didn't think about that. We need to update to parser. See SassDoc/scss-comment-parser#11

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Aug 17, 2014

Member

Fixed in scss-comment-parser@0.2.3

Member

FWeinb commented Aug 17, 2014

Fixed in scss-comment-parser@0.2.3

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Aug 18, 2014

Member

Done in the theme. It's perfect, awesome work Fab.

Member

HugoGiraudel commented Aug 18, 2014

Done in the theme. It's perfect, awesome work Fab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment