Add CRUDs for missing fields for API Hosts entity #4118

svtkachenko · 2016-12-23T17:08:42Z

Part of #3270, depends on SatelliteQE/nailgun#346 and SatelliteQE/nailgun#347.
test_positive_update_provision_method was not added as "Provision method can't be updated after host is provisioned".

% pytest -v tests/foreman/api/test_host.py -k 'test_positive_create_with_puppet_class or test_positive_create_with_content_view or test_positive_create_with_host_parameters or test_positive_create_with_image or test_positive_create_with_provision_method or test_positive_update_puppet_class or test_positive_update_content_view or test_positive_update_host_parameters or test_positive_update_image or test_positive_update_provision_method'
===================================================================== test session starts =====================================================================
platform linux2 -- Python 2.7.12, pytest-3.0.4, py-1.4.31, pluggy-0.4.0 -- /home/qui/code/venv/2/bin/python2
cachedir: .cache
rootdir: /home/qui/code/robottelo, inifile: 
plugins: xdist-1.15.0, html-1.12.0, cov-2.4.0
collected 60 items 

tests/foreman/api/test_host.py::HostTestCase::test_positive_create_with_content_view <- robottelo/decorators/__init__.py PASSED
tests/foreman/api/test_host.py::HostTestCase::test_positive_create_with_host_parameters <- robottelo/decorators/__init__.py PASSED
tests/foreman/api/test_host.py::HostTestCase::test_positive_create_with_image <- robottelo/decorators/__init__.py PASSED
tests/foreman/api/test_host.py::HostTestCase::test_positive_create_with_provision_method <- robottelo/decorators/__init__.py PASSED
tests/foreman/api/test_host.py::HostTestCase::test_positive_create_with_puppet_class <- robottelo/decorators/__init__.py PASSED
tests/foreman/api/test_host.py::HostTestCase::test_positive_update_content_view <- robottelo/decorators/__init__.py PASSED
tests/foreman/api/test_host.py::HostTestCase::test_positive_update_host_parameters <- robottelo/decorators/__init__.py PASSED
tests/foreman/api/test_host.py::HostTestCase::test_positive_update_image <- robottelo/decorators/__init__.py PASSED
tests/foreman/api/test_host.py::HostTestCase::test_positive_update_puppet_class <- robottelo/decorators/__init__.py PASSED

===================================================================== 51 tests deselected =====================================================================
========================================================== 9 passed, 51 deselected in 177.73 seconds ==========================================================

coveralls · 2016-12-23T17:12:15Z

Coverage remained the same at 74.596% when pulling f651cdc on svtkachenko:host_cruds into 07ef69c on SatelliteQE:master.

coveralls · 2016-12-23T17:12:15Z

Coverage remained the same at 74.596% when pulling f651cdc on svtkachenko:host_cruds into 07ef69c on SatelliteQE:master.

oshtaier · 2016-12-28T08:58:09Z

tests/foreman/api/test_host.py

@@ -22,7 +22,11 @@
 from fauxfactory import gen_integer, gen_ipaddr, gen_mac, gen_string
 from nailgun import client, entities
 from requests.exceptions import HTTPError
+from six.moves import http_client


why did you move it there? Put it back and remove redundant empty line

Isn't six a third-party module?
And according to http://robottelo.readthedocs.io/en/latest/code_standards.html#recommended
third-party should be placed before application-specific and separated with a blank line between groups of imports.

I agree with you and most of times I refactored my code to put them all together. I knew pep8 state about importing but never realized robottello doc itself mention the exactly same format. Maybe it's worth a email or issue discussion about it so everyone get aware of this. I would be happier once Pycharm follow pep 8 as well ;)

oshtaier · 2016-12-28T08:58:36Z

tests/foreman/api/test_host.py

+        super(HostTestCase, cls).setUpClass()
+        cls.org = entities.Organization().create()
+        cls.loc = entities.Location(organization=[cls.org]).create()
+        # Content View and repository reloated entities


reloated?

oshtaier · 2016-12-28T09:14:31Z

tests/foreman/api/test_host.py

+            query={'search': u'content_view="{0}"'.format(cls.cv.name)}
+        )[0].read()
+        cls.lce = entities.LifecycleEnvironment().search(query={
+            'search': 'name=Library and organization_id={0}'.format(


name=ENVIRONMENT

oshtaier · 2016-12-28T09:20:10Z

tests/foreman/api/test_host.py

@@ -383,6 +437,95 @@ def test_positive_create_with_compute_profile(self):
        self.assertEqual(host.compute_profile.read().name, profile.name)

    @run_only_on('sat')
+    @tier2
+    def test_positive_create_with_content_view(self):


Basically, covered in https://github.com/SatelliteQE/robottelo/blob/master/tests/foreman/api/test_contentview.py#L94
But probably, that one is more basic

oshtaier · 2016-12-28T09:24:07Z

ACK pending nitpicks

coveralls · 2016-12-28T10:45:02Z

Coverage remained the same at 74.596% when pulling c1f7bd2 on svtkachenko:host_cruds into 07ef69c on SatelliteQE:master.

renzon

ACK

* Add CRUDs for missing fields for API Hosts entity (#4118) * Add CRUDs for missing fields for API Hosts entity * Changes according to review comments. * Changes specific for 6.2

Add CRUDs for missing fields for API Hosts entity

f651cdc

svtkachenko added 6.3 API Issues and PRs involving the API labels Dec 23, 2016

svtkachenko mentioned this pull request Dec 26, 2016

Add CRUDs for missing fields for API Hosts entity #3270

Closed

10 tasks

oshtaier suggested changes Dec 28, 2016

View reviewed changes

Changes according to review comments.

c1f7bd2

oshtaier approved these changes Dec 28, 2016

View reviewed changes

renzon approved these changes Jan 2, 2017

View reviewed changes

renzon merged commit 385b203 into SatelliteQE:master Jan 2, 2017

renzon removed the review label Jan 2, 2017

renzon mentioned this pull request Jan 5, 2017

PEP8 and Robottelo style guide #4141

Closed

svtkachenko mentioned this pull request Jan 19, 2017

[6.2.z] Add CRUDs for missing fields for API Hosts entity #4205

Merged

svtkachenko deleted the host_cruds branch February 22, 2017 14:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CRUDs for missing fields for API Hosts entity #4118

Add CRUDs for missing fields for API Hosts entity #4118

svtkachenko commented Dec 23, 2016

coveralls commented Dec 23, 2016

coveralls commented Dec 23, 2016

oshtaier Dec 28, 2016

svtkachenko Dec 28, 2016

renzon Jan 2, 2017

oshtaier Dec 28, 2016

oshtaier Dec 28, 2016

oshtaier Dec 28, 2016

oshtaier commented Dec 28, 2016

coveralls commented Dec 28, 2016 •

edited

Loading

renzon left a comment

Add CRUDs for missing fields for API Hosts entity #4118

Add CRUDs for missing fields for API Hosts entity #4118

Conversation

svtkachenko commented Dec 23, 2016

coveralls commented Dec 23, 2016

coveralls commented Dec 23, 2016

oshtaier Dec 28, 2016

Choose a reason for hiding this comment

svtkachenko Dec 28, 2016

Choose a reason for hiding this comment

renzon Jan 2, 2017

Choose a reason for hiding this comment

oshtaier Dec 28, 2016

Choose a reason for hiding this comment

oshtaier Dec 28, 2016

Choose a reason for hiding this comment

oshtaier Dec 28, 2016

Choose a reason for hiding this comment

oshtaier commented Dec 28, 2016

coveralls commented Dec 28, 2016 • edited Loading

renzon left a comment

Choose a reason for hiding this comment

coveralls commented Dec 28, 2016 •

edited

Loading