Mark manifester tests that do not use manifester fixtures #14521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@synkd This would be the alternative to #14405 discussed here #14405 (comment) |
rplevka
approved these changes
May 16, 2024
pnovotny
approved these changes
May 31, 2024
dosas
added
CherryPick
|
@dosas No idea, but I can try. Any particular build in mind? |
The stuck pre-commit |
|
I see that all Code Quality 3.10/3.11/3.12 Pre Commit Checks passed: |
but instantiate Manifester directly
dosas
force-pushed
the
mark-manifester-tests
branch
from
c78661c to
44f45ef
Compare
|
After rebase I also see everything is green. So there is nothing blocking the merge? |
synkd
approved these changes
Jun 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
but instantiate Manifester directly (cherry picked from commit 081fbea)
jyejare
pushed a commit
that referenced
this pull request
Jun 21, 2024
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
…E#14521) but instantiate Manifester directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Tests that do not use manifester fixture cannot be filtered by https://github.com/SatelliteQE/robottelo/blob/master/tests/foreman/conftest.py#L33
Solution
Add simple pytest mark.
Related Issues
#14405