Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

katello_host_tools_host no disable sca #14877

Merged
merged 1 commit into from
May 21, 2024
Merged

katello_host_tools_host no disable sca #14877

merged 1 commit into from
May 21, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

sca default in 6.16

Solution

rid of sca_disable

@pondrejk pondrejk added the No-CherryPick PR doesnt need CherryPick to previous branches label Apr 24, 2024
@pondrejk pondrejk self-assigned this Apr 24, 2024
@pondrejk pondrejk requested a review from a team as a code owner April 24, 2024 12:05
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_report_package_installed_removed[rhel7]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6674
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_report_package_installed_removed[rhel7] --external-logging
Test Result : =========== 89 deselected, 98 warnings, 1 error in 719.67s (0:11:59) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 24, 2024
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_report_package_installed_removed[rhel7]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6678
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_report_package_installed_removed[rhel7] --external-logging
Test Result : ========== 1 failed, 89 deselected, 98 warnings in 751.33s (0:12:31) ===========

@pondrejk pondrejk marked this pull request as draft April 24, 2024 13:33
@pondrejk pondrejk marked this pull request as ready for review May 7, 2024 09:13
@pondrejk
Copy link
Contributor Author

pondrejk commented May 7, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_install_package_via_rex[rhel7]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6815
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_install_package_via_rex[rhel7] --external-logging
Test Result : ========== 1 failed, 85 deselected, 98 warnings in 1051.08s (0:17:31) ==========

@pondrejk
Copy link
Contributor Author

pondrejk commented May 7, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_package_applicability[rhel8]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6831
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k  test_positive_package_applicability[rhel8] --external-logging
Test Result : ========== 1 failed, 85 deselected, 94 warnings in 758.76s (0:12:38) ===========

@pondrejk
Copy link
Contributor Author

pondrejk commented May 7, 2024

well, tests affected by this problem no longer hit it after PR, but they don't pass due to other reasons (hammer.parse_info needs some love). I'll leave up to reviewers if we want to get this in anyway or to wait on the other fixes

@pondrejk
Copy link
Contributor Author

pondrejk commented May 9, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_syspurpose

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6858
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py  -k test_syspurpose --external-logging
Test Result : ========== 1 failed, 86 deselected, 96 warnings in 423.23s (0:07:03) ===========

@pondrejk
Copy link
Contributor Author

pondrejk commented May 9, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_syspurpose

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6865
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_syspurpose --external-logging
Test Result : ========== 1 failed, 86 deselected, 96 warnings in 733.22s (0:12:13) ===========

@pondrejk pondrejk requested a review from a team as a code owner May 9, 2024 17:02
@pondrejk
Copy link
Contributor Author

pondrejk commented May 9, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_syspurpose

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6869
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_syspurpose --external-logging
Test Result : ========== 1 failed, 86 deselected, 96 warnings in 748.99s (0:12:28) ===========

@pondrejk
Copy link
Contributor Author

pondrejk commented May 9, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_syspurpose

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6870
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_syspurpose --external-logging
Test Result : ========== 1 failed, 86 deselected, 96 warnings in 714.38s (0:11:54) ===========

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_package_applicability[rhel8]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6877
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_package_applicability[rhel8] --external-logging
Test Result : ========== 1 passed, 86 deselected, 95 warnings in 744.92s (0:12:24) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 10, 2024
@pondrejk
Copy link
Contributor Author

sorry for the excess of prt comments (local setup issues on my side)

@vsedmik
Copy link
Contributor

vsedmik commented May 20, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_syspurpose

vsedmik
vsedmik reviewed May 20, 2024
View reviewed changes
tests/foreman/cli/test_host.py
@@ -2294,7 +2269,7 @@ def test_syspurpose_end_to_end(
)
host = target_sat.cli.Host.info({'id': host['id']})
# Assert system purpose values have been updated in the host as expected
assert host['subscription-information']['system-purpose']['purpose-addons'] == "test-addon3"
assert host['subscription-information']['system-purpose']['purpose-addons'][0] == "test-addon3"
assert host['subscription-information']['system-purpose']['purpose-role'] == "test-role2"
assert host['subscription-information']['system-purpose']['purpose-usage'] == "test-usage2"
assert host['subscription-information']['system-purpose']['service-level'] == "Self-Support2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the following will lines need a change too

host_subscriptions = target_sat.cli.ActivationKey.subscriptions(
        {
            'organization-id': module_org.id,
            'id': activation_key.id,
            'host-id': host['id'],
        },
        output_format='json',
    )
assert len(host_subscriptions) > 0

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7010
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_syspurpose --external-logging
Test Result : ========== 1 failed, 86 deselected, 95 warnings in 719.75s (0:11:59) ===========

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels May 20, 2024
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_syspurpose

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7013
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_syspurpose --external-logging
Test Result : ========== 1 passed, 86 deselected, 95 warnings in 819.98s (0:13:39) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 20, 2024
@pondrejk pondrejk merged commit e040183 into SatelliteQE:master May 21, 2024
11 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@pondrejk @jyejare
katello_host_tools_host no disable sca (SatelliteQE#14877)
34d53f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@pondrejk pondrejk

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pondrejk @Satellite-QE @vsedmik @JacobCallahan