policy list should work after associated hg removal #15031

pondrejk · 2024-05-10T11:26:28Z

Problem Statement

SAT-19502 describes the issue, https://github.com/theforeman/foreman_openscap/pull/568/files provides the upstream fix

Solution

Extending an existing test to check the policy behavior after hostgroup removal

Related Issues

pondrejk · 2024-05-10T11:31:49Z

"trigger": "test-robottelo"
"pytest": "tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups"
"theforeman":
    "foreman_openscap": "568"

Satellite-QE · 2024-05-10T12:05:02Z

PRT Result

Build Number: 6878
Build Status: SUCCESS
PRT Comment: pytest /opt/app-root/src/robottelo/tests/foreman -v -m build_sanity --external-logging
Test Result : ======= 12 passed, 5423 deselected, 5526 warnings in 1685.28s (0:28:05) ========

pondrejk · 2024-05-10T12:18:54Z

Disregard the prt run, the test collection there didn't match my comment, so I killed the job, investigating...

Griffin-Sullivan · 2024-05-10T12:22:32Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups
theforeman:
    foreman_openscap: 568

Satellite-QE · 2024-05-10T12:59:04Z

PRT Result

Build Number: 6879
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups --external-logging
Test Result : ========== 1 passed, 70 deselected, 79 warnings in 1633.87s (0:27:13) ==========

Griffin-Sullivan · 2024-05-10T13:03:28Z

tests/foreman/cli/test_oscap.py

+        try:
+            module_target_sat.cli.Scappolicy.list()
+        except CLIReturnCodeError:
+            pytest.fail("failed to list policies")


Why are we catching the failure?

I believe that plain raising of the exception results in Error junit status. If you properly fail it, you get Failed status.

True, CLIReturnCodeError doesn't inherit from AssertionError so the test would result as Error. And unfortunately pytest doesn't have anything like pytest.not_raises() (yet), which would be cool for these cases.

lhellebr · 2024-05-10T14:31:44Z

tests/foreman/cli/test_oscap.py

+        module_target_sat.cli.HostGroup.delete({'id': hostgroup['id']})
+        # removal of hostgroup shouldn't affect policies
+        try:
+            module_target_sat.cli.Scappolicy.list()


Shouldn't you assert the policies have indeed been listed?

rplevka

ACK after adressing @lhellebr 's comment

rplevka · 2024-05-15T05:36:45Z

tests/foreman/cli/test_oscap.py

+        try:
+            module_target_sat.cli.Scappolicy.list()
+        except CLIReturnCodeError:
+            pytest.fail("failed to list policies")


I believe that plain raising of the exception results in Error junit status. If you properly fail it, you get Failed status.

pnovotny · 2024-05-17T14:01:36Z

I would also add some assertion like @lhellebr mentioned.
Otherwise LGTM.

pondrejk · 2024-05-20T11:01:22Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups
theforeman:
    foreman_openscap: 572

Satellite-QE · 2024-05-20T11:30:49Z

PRT Result

Build Number: 7012
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups --external-logging
Test Result : ========== 70 deselected, 76 warnings, 1 error in 1425.38s (0:23:45) ===========

pondrejk · 2024-05-20T11:48:04Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups
theforeman:
    foreman_openscap: 572

Satellite-QE · 2024-05-20T12:18:14Z

PRT Result

Build Number: 7015
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups --external-logging
Test Result : ========== 70 deselected, 76 warnings, 1 error in 1247.67s (0:20:47) ===========

pondrejk · 2024-05-27T08:29:46Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups

Satellite-QE · 2024-05-27T08:49:29Z

PRT Result

Build Number: 7124
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups --external-logging
Test Result : =========== 70 deselected, 78 warnings, 1 error in 717.56s (0:11:57) ===========

jameerpathan111 · 2024-06-05T09:07:06Z

tests/foreman/cli/test_oscap.py


        :expectedresults: The policy is created and associated successfully.
+            Policies can be listed after hostgroup removal.
+
+        :bz: 1728157


Suggested change

:bz: 1728157

:bz: 1728157

:Verifies: SAT-19502

@pondrejk As we're moving away from Bugzilla, could we also add Jira issue here?

ogajduse

ACK, one minor comment left.

co-reviewed with @jameerpathan111

ogajduse · 2024-06-05T09:12:51Z

tests/foreman/cli/test_oscap.py

+        # removal of hostgroup shouldn't affect policies
+        try:
+            result = module_target_sat.cli.Scappolicy.list()
+            assert name in [policy['name'] for policy in result]


Minor one: since CLIReturnCodeError can not be raised here, you can move this line below the except block.
Edit: commenting on line assert name in [policy['name'] for policy in result]

pondrejk · 2024-06-11T08:30:14Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups

pondrejk · 2024-06-11T12:41:13Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups

Satellite-QE · 2024-06-11T12:57:07Z

PRT Result

Build Number: 7357
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_oscap.py -k test_positive_associate_scap_policy_with_hostgroups --external-logging
Test Result : ========== 1 passed, 70 deselected, 79 warnings in 651.18s (0:10:51) ===========

pondrejk added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels May 10, 2024

pondrejk self-assigned this May 10, 2024

pondrejk requested a review from a team as a code owner May 10, 2024 11:26

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 10, 2024

pondrejk removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 10, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 10, 2024

Griffin-Sullivan approved these changes May 10, 2024

View reviewed changes

lhellebr reviewed May 10, 2024

View reviewed changes

pondrejk mentioned this pull request May 13, 2024

Fixes #27259 - Fix hostgroup-asset association theforeman/foreman_openscap#568

Merged

rplevka requested changes May 15, 2024

View reviewed changes

Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels May 20, 2024

pondrejk force-pushed the test-orphaned branch from 3484529 to 8105d63 Compare May 27, 2024 09:51

lhellebr approved these changes May 27, 2024

View reviewed changes

pnovotny approved these changes May 27, 2024

View reviewed changes

jameerpathan111 reviewed Jun 5, 2024

View reviewed changes

jameerpathan111 approved these changes Jun 5, 2024

View reviewed changes

ogajduse approved these changes Jun 5, 2024

View reviewed changes

policy list should work after associated hg removal

0b4d62c

pondrejk force-pushed the test-orphaned branch from 8105d63 to 0b4d62c Compare June 11, 2024 08:28

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 11, 2024

pondrejk merged commit ca9193d into SatelliteQE:master Jun 11, 2024
11 checks passed

jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024

policy list should work after associated hg removal (SatelliteQE#15031)

dc69ee1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

policy list should work after associated hg removal #15031

policy list should work after associated hg removal #15031

pondrejk commented May 10, 2024

pondrejk commented May 10, 2024

Satellite-QE commented May 10, 2024

pondrejk commented May 10, 2024

Griffin-Sullivan commented May 10, 2024

Satellite-QE commented May 10, 2024

Griffin-Sullivan May 10, 2024

rplevka May 15, 2024

pnovotny May 17, 2024

lhellebr May 10, 2024

rplevka left a comment

rplevka May 15, 2024

pnovotny commented May 17, 2024

pondrejk commented May 20, 2024

Satellite-QE commented May 20, 2024

pondrejk commented May 20, 2024

Satellite-QE commented May 20, 2024

pondrejk commented May 27, 2024

Satellite-QE commented May 27, 2024

jameerpathan111 Jun 5, 2024

pondrejk Jun 11, 2024

ogajduse left a comment

ogajduse Jun 5, 2024 •

edited

Loading

pondrejk commented Jun 11, 2024

pondrejk commented Jun 11, 2024

Satellite-QE commented Jun 11, 2024

policy list should work after associated hg removal #15031

policy list should work after associated hg removal #15031

Conversation

pondrejk commented May 10, 2024

Problem Statement

Solution

Related Issues

pondrejk commented May 10, 2024

Satellite-QE commented May 10, 2024

pondrejk commented May 10, 2024

Griffin-Sullivan commented May 10, 2024

Satellite-QE commented May 10, 2024

Griffin-Sullivan May 10, 2024

Choose a reason for hiding this comment

rplevka May 15, 2024

Choose a reason for hiding this comment

pnovotny May 17, 2024

Choose a reason for hiding this comment

lhellebr May 10, 2024

Choose a reason for hiding this comment

rplevka left a comment

Choose a reason for hiding this comment

rplevka May 15, 2024

Choose a reason for hiding this comment

pnovotny commented May 17, 2024

pondrejk commented May 20, 2024

Satellite-QE commented May 20, 2024

pondrejk commented May 20, 2024

Satellite-QE commented May 20, 2024

pondrejk commented May 27, 2024

Satellite-QE commented May 27, 2024

jameerpathan111 Jun 5, 2024

Choose a reason for hiding this comment

pondrejk Jun 11, 2024

Choose a reason for hiding this comment

ogajduse left a comment

Choose a reason for hiding this comment

ogajduse Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

pondrejk commented Jun 11, 2024

pondrejk commented Jun 11, 2024

Satellite-QE commented Jun 11, 2024

ogajduse Jun 5, 2024 •

edited

Loading