Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for syncable export with restrictive permissions #15090

Merged
merged 1 commit into from
May 21, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented May 16, 2024

Problem Statement

Coverage for BZ#2233162 is missing

Solution

This PR.
metadata.json is the only exception where restrictive permissions are expected

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k permissions

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 16, 2024
@vsedmik vsedmik self-assigned this May 16, 2024
@vsedmik vsedmik requested a review from a team as a code owner May 16, 2024 18:35
@vsedmik
Copy link
Contributor Author

vsedmik commented May 16, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k permissions

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6970
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_satellitesync.py -k permissions --external-logging
Test Result : ========== 1 passed, 33 deselected, 42 warnings in 784.37s (0:13:04) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 16, 2024
Copy link
Contributor

@rmynar rmynar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be sure that all involved components (services) use the modified umask settings? May it be useful to launch satellite-maintain service restart when changing umask?

@vsedmik
Copy link
Contributor Author

vsedmik commented May 20, 2024

Can we be sure that all involved components (services) use the modified umask settings? May it be useful to launch satellite-maintain service restart when changing umask?

The issue was that the rights of the user executing the export command were used for the exported files. This way we set it globally for whatever user is used by target_sat.execute(), so IMHO no service restart is necessary.

@rmynar
Copy link
Contributor

rmynar commented May 20, 2024

Can we be sure that all involved components (services) use the modified umask settings? May it be useful to launch satellite-maintain service restart when changing umask?

The issue was that the rights of the user executing the export command were used for the exported files. This way we set it globally for whatever user is used by target_sat.execute(), so IMHO no service restart is necessary.

Sounds good, ACK :)

@pondrejk pondrejk merged commit d4c0c83 into SatelliteQE:master May 21, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 21, 2024
Add test for syncable export with restrictive perms

(cherry picked from commit d4c0c83)
vsedmik added a commit that referenced this pull request May 21, 2024
…15115)

Add test for syncable export with restrictive permissions (#15090)

Add test for syncable export with restrictive perms

(cherry picked from commit d4c0c83)

Co-authored-by: vsedmik <46570670+vsedmik@users.noreply.github.com>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants