Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused functions and fix incorrect validators and remove unused ones #15277

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Remove unused functions and fix incorrect validators and remove unused ones #15277

merged 1 commit into from
Jun 3, 2024

Conversation

ogajduse
Copy link
Member

@ogajduse ogajduse commented Jun 3, 2024

Problem Statement

  • Failing validation that results in some validators not being run and therefore setting defaults not being set.

Solution

  • Remove and fix validators that are no longer valid or used

Related Issues

@ogajduse ogajduse requested a review from a team as a code owner June 3, 2024 16:46
@ogajduse ogajduse added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 3, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit c6a182c into SatelliteQE:master Jun 3, 2024
11 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 3, 2024
@ogajduse @web-flow
Remove unused functions and fix incorrect validators and remove unuse…
5677de4 
…d ones (#15277)

(cherry picked from commit c6a182c)
This was referenced Jun 3, 2024
Merged
Closed
Closed
Closed
Gauravtalreja1 pushed a commit that referenced this pull request Jun 3, 2024
@Satellite-QE @ogajduse
[6.16.z] Remove unused functions and fix incorrect validators and rem…
658e76a 
…ove unused ones (#15280)

Remove unused functions and fix incorrect validators and remove unused ones (#15277)

(cherry picked from commit c6a182c)

Co-authored-by: Ondřej Gajdušek <ogajduse@redhat.com>
ogajduse added a commit to ogajduse/robottelo that referenced this pull request Jun 4, 2024
@ogajduse
Remove unused functions and fix incorrect validators and remove unuse…
691229a 
…d ones (SatelliteQE#15277)

(cherry picked from commit c6a182c)
ogajduse added a commit to ogajduse/robottelo that referenced this pull request Jun 4, 2024
@ogajduse
Remove unused functions and fix incorrect validators and remove unuse…
6a5dfee 
…d ones (SatelliteQE#15277)

(cherry picked from commit c6a182c)
ogajduse added a commit to ogajduse/robottelo that referenced this pull request Jun 4, 2024
@ogajduse
Remove unused functions and fix incorrect validators and remove unuse…
1d50b21 
…d ones (SatelliteQE#15277)

(cherry picked from commit c6a182c)
This was referenced Jun 4, 2024
Merged
Merged
Merged
@ogajduse ogajduse deleted the fix/validators-n-dead-code branch June 4, 2024 10:04
Gauravtalreja1 pushed a commit that referenced this pull request Jun 4, 2024
@ogajduse
[6.13.z] Remove unused functions and fix incorrect validators and rem…
82535a6 
…ove unused ones (#15290)

Remove unused functions and fix incorrect validators and remove unused ones (#15277)

(cherry picked from commit c6a182c)
Gauravtalreja1 pushed a commit that referenced this pull request Jun 4, 2024
@ogajduse
[6.14.z] Remove unused functions and fix incorrect validators and rem…
18491f1 
…ove unused ones (#15291)

Remove unused functions and fix incorrect validators and remove unused ones (#15277)

(cherry picked from commit c6a182c)
Gauravtalreja1 pushed a commit that referenced this pull request Jun 4, 2024
@ogajduse
[6.15.z] Remove unused functions and fix incorrect validators and rem…
7278d1e 
…ove unused ones (#15292)

Remove unused functions and fix incorrect validators and remove unused ones (#15277)

(cherry picked from commit c6a182c)
@lpramuk lpramuk mentioned this pull request Jun 17, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@ogajduse @jyejare
Remove unused functions and fix incorrect validators and remove unuse…
bf390f1 
…d ones (SatelliteQE#15277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees

@ogajduse ogajduse

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogajduse @jameerpathan111 @Gauravtalreja1