Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed server.hostname validator for resolve rhel 8.10 formatting issue #15340

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

omkarkhatavkar
Copy link

Problem Statement

Solution

Related Issues

@omkarkhatavkar omkarkhatavkar requested a review from a team as a code owner June 6, 2024 13:51
@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 6, 2024
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To curb the need of sign-off of 6.15.1 GA , merging this on priority as this has been verified locally that the rhel version is being translated as expected.

The FIPS pipeline has run with this change by exporting env var with very similar approach and it worked.

Considering all this in mind, merging the PR now.

@jyejare jyejare enabled auto-merge (squash) June 6, 2024 13:56
@omkarkhatavkar omkarkhatavkar force-pushed the remove_defaul_value branch 3 times, most recently from a1de45f to 0a76678 Compare June 6, 2024 14:20
@jyejare jyejare merged commit 68d3199 into SatelliteQE:master Jun 6, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
omkarkhatavkar added a commit that referenced this pull request Jun 6, 2024
…atting issue (#15344)

removed server.hostname validator for resolve rhel 8.10 formatting issue (#15340)

(cherry picked from commit 68d3199)

Co-authored-by: Omkar Khatavkar <okhatavkar007@gmail.com>
omkarkhatavkar added a commit that referenced this pull request Jun 6, 2024
…atting issue (#15343)

removed server.hostname validator for resolve rhel 8.10 formatting issue (#15340)

(cherry picked from commit 68d3199)

Co-authored-by: Omkar Khatavkar <okhatavkar007@gmail.com>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants