Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPA and RHSSO. #15357

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix IPA and RHSSO. #15357

merged 1 commit into from
Jun 11, 2024

Conversation

lhellebr
Copy link
Contributor

@lhellebr lhellebr commented Jun 6, 2024

IPA domain isn't necessarily the same as DNS domain so connect using DNS domain and there detect the actual IPA domain.

RHSSO used nonexistent ssh_session methods, perhaps this has changed over time. I made it use the execute method and workarounded bug that happens when calling 'hammer auth login oauth' non-interactively by faking tty.

@lhellebr lhellebr requested review from a team as code owners June 6, 2024 17:24
@lhellebr
Copy link
Contributor Author

lhellebr commented Jun 6, 2024

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer

@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 6, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7316
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer --external-logging
Test Result : ================== 12 warnings, 1 error in 1413.09s (0:23:33) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 6, 2024
@lhellebr lhellebr force-pushed the fix_ipa_and_rhsso branch from 1b415d5 to 7bb3d2d Compare June 10, 2024 13:23
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7334
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer --external-logging
Test Result : ================= 1 passed, 17 warnings in 2302.09s (0:38:22) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 10, 2024
Copy link
Contributor

@lpramuk lpramuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just enhance comment and put JIRA bug # in it

tests/foreman/destructive/test_ldapauthsource.py Outdated Show resolved Hide resolved
IPA domain isn't necessarily the same as DNS domain so connect using DNS domain and there detect the actual IPA domain.
RHSSO used nonexistent ssh_session methods, perhaps this has changed over time. I made it use the execute method and workarounded bug that happens when calling 'hammer auth login oauth' non-interactively by faking tty.
@lhellebr lhellebr force-pushed the fix_ipa_and_rhsso branch from 7bb3d2d to 71bf9d1 Compare June 11, 2024 11:26
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 11, 2024
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer

@lhellebr
Copy link
Contributor Author

PRT passed before changing the comment so issue probably unrelated. I can't get the run logs so I don't know what happened...

@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer

@pondrejk pondrejk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 11, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7364
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer --external-logging
Test Result : ================= 1 passed, 17 warnings in 2279.32s (0:37:59) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 11, 2024
@pondrejk pondrejk merged commit 5ce77c1 into SatelliteQE:master Jun 11, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
IPA domain isn't necessarily the same as DNS domain so connect using DNS domain and there detect the actual IPA domain.
RHSSO used nonexistent ssh_session methods, perhaps this has changed over time. I made it use the execute method and workarounded bug that happens when calling 'hammer auth login oauth' non-interactively by faking tty.

(cherry picked from commit 5ce77c1)
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
IPA domain isn't necessarily the same as DNS domain so connect using DNS domain and there detect the actual IPA domain.
RHSSO used nonexistent ssh_session methods, perhaps this has changed over time. I made it use the execute method and workarounded bug that happens when calling 'hammer auth login oauth' non-interactively by faking tty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants