Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old skip_if for closed BZs #15370

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jun 7, 2024

Problem Statement

These BZs were already closed so we don't need to skip if open them anymore:
https://bugzilla.redhat.com/show_bug.cgi?id=1802395
https://bugzilla.redhat.com/show_bug.cgi?id=1789028
https://bugzilla.redhat.com/show_bug.cgi?id=2112320
https://bugzilla.redhat.com/show_bug.cgi?id=1680458
https://bugzilla.redhat.com/show_bug.cgi?id=2148813

Solution

Remove the skip_if conditioning.

PRT

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py::test_positive_lock_clone_nodelete_unlock_report tests/foreman/cli/test_activationkey.py::test_create_ak_with_syspurpose_set tests/foreman/ui/test_containerimagetag.py::test_positive_search

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 7, 2024
@vsedmik vsedmik requested a review from yanpliu June 7, 2024 07:41
@vsedmik vsedmik self-assigned this Jun 7, 2024
@vsedmik vsedmik requested review from a team as code owners June 7, 2024 07:41
@vsedmik
Copy link
Contributor Author

vsedmik commented Jun 7, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py::test_positive_lock_clone_nodelete_unlock_report tests/foreman/cli/test_activationkey.py::test_create_ak_with_syspurpose_set tests/foreman/ui/test_containerimagetag.py::test_positive_search

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7318
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_reporttemplates.py::test_positive_lock_clone_nodelete_unlock_report tests/foreman/cli/test_activationkey.py::test_create_ak_with_syspurpose_set tests/foreman/ui/test_containerimagetag.py::test_positive_search --external-logging
Test Result : ============= 2 passed, 68 warnings, 1 error in 917.13s (0:15:17) ==============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 7, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Jun 7, 2024

The single PRT failure above is related to SCA-only, which won't be CPed with this PR.

@vsedmik
Copy link
Contributor Author

vsedmik commented Jun 7, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py::test_positive_lock_clone_nodelete_unlock_report tests/foreman/cli/ tests/foreman/ui/test_containerimagetag.py::test_positive_search

Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are strainght forward.

Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants