Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify ansible variable test to cover non-admin scenario #15416

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Modify ansible variable test to cover non-admin scenario #15416

merged 1 commit into from
Jun 17, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Currently, ansible variable test covers only admin scenario, and as part of component audit its suggest to modify this test to cover non-admin user scenario as well, and delete the duplicate test which test create delete

Solution

  • Parametrizing the existing test to cover both admin and non-admin user scenarios with few more fixes
  • Deleting the test test_positive_create_and_delete_variable which tests create delete which is covered already in other test.

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 14, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Jun 14, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner June 14, 2024 17:03
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_create_delete_variable_with_overrides

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7397
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_create_delete_variable_with_overrides --external-logging
Test Result : ================== 2 passed, 36 warnings in 761.38s (0:12:41) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 14, 2024
@Gauravtalreja1
Modify ansible variable test to cover non-admin scenario
05bee94 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
@Gauravtalreja1 Gauravtalreja1 force-pushed the ansible-variable-ui-test-non-admin branch from 2b4f40d to 05bee94 Compare June 14, 2024 21:01
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_create_delete_variable_with_overrides

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 14, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7399
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_create_delete_variable_with_overrides --external-logging
Test Result : ================== 2 passed, 41 warnings in 793.18s (0:13:13) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 14, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from synkd June 15, 2024 01:28
@synkd synkd merged commit ec71335 into SatelliteQE:master Jun 17, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@Gauravtalreja1 @web-flow
Modify ansible variable test to cover non-admin scenario (#15416)
00e9b33 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit ec71335)
@Satellite-QE Satellite-QE mentioned this pull request Jun 17, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@Gauravtalreja1 @web-flow
Modify ansible variable test to cover non-admin scenario (#15416)
b380803 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit ec71335)
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@Gauravtalreja1 @web-flow
Modify ansible variable test to cover non-admin scenario (#15416)
846e967 
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit ec71335)
This was referenced Jun 17, 2024
Merged
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the ansible-variable-ui-test-non-admin branch June 17, 2024 23:15
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Gauravtalreja1 @jyejare
Modify ansible variable test to cover non-admin scenario (SatelliteQE…
0bb60a3 
…#15416)

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@synkd synkd synkd approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @Satellite-QE @jameerpathan111 @synkd