-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for overriding jira issues to comment on. #15427
Add support for overriding jira issues to comment on. #15427
Conversation
|
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK with non-blocking suggestion.
pytest_plugins/jira_comments.py
Outdated
@@ -8,16 +8,29 @@ | |||
from robottelo.utils.issue_handlers.jira import add_comment_on_jira | |||
|
|||
|
|||
def parse_comma_separated_list(option_value): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice utils function, move this to utils init module in robottelo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the PR, and moved it to the utils init module in robottelo.
@devendra104 @omkarkhatavkar We had to use this PR functioning in a standalone PRT job (and for those upstream PR testing) which does not needs PR to open for running regression tests. In short, we have to introduce new |
bdaff57
to
68de3d1
Compare
|
PRT Result
|
(cherry picked from commit 91f875b)
(cherry picked from commit 91f875b)
(cherry picked from commit 91f875b)
Problem Statement
--jira-comments
pytest option that we use to add comments to Jira issues for tests marked withVerifies
orBlockedBy
doc fields. Atm, this can't be overridden, and one has to mark each test with these fields.Solution
--jira-comments
to override issues to comment test results on.Usage
pytest tests/foreman/api/test_ping.py --jira-comments
Comment test results on issues mentioned inVerifies
andBlockedBy
doc fields(No change, this is primary use case).pytest tests/foreman/api/test_ping.py --jira-comments 'SAT-24796,SAT-25230'
Comment test results onSAT-24796
andSAT-25230
.Related Issues