Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check subscription header and message on manage manifest page #15500

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Jun 25, 2024

Problem Statement

  • Considering newly implemented 6.16.0 feature/RFE "Notification when manifest is going to expire" and reported bug "Manifest expiration date (year) shows older for all manifest" it is neccessary to check manifest expiration message is disappearing when manifest upload very first time into organization.
  • It was left behind because related airgun PR merged very early phase of testing.
  • During phoenix qe team discussion, we have decided to open new robottelo PR and airgun PR to validate manifest expiration header message functionality before updating settings value (expire_soon_days)

Solution

Simple assertion is required in existing test case

Related PR

Airgun support SatelliteQE/airgun#1443

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1443

@vijaysawant vijaysawant added Stream Introduced in or relating directly to Satellite Stream/Master No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 25, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1443

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7496
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 20 warnings in 907.94s (0:15:07) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 25, 2024
@vijaysawant vijaysawant marked this pull request as ready for review June 25, 2024 11:42
@vijaysawant vijaysawant requested a review from a team as a code owner June 25, 2024 11:42
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1443

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7525
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 20 warnings in 900.82s (0:15:00) ===========

@vsedmik vsedmik merged commit 099d307 into SatelliteQE:master Jun 26, 2024
11 of 12 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants