Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for SAT-24197 #15521

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Missing test coverage for SAT-24197, to verify foreman-discovery-image is built on latest up-to-date RHEL

Solution

Add test coverage for SAT-24197, to verify foreman-discovery-image is built on latest up-to-date RHEL

Related Issues

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 26, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Jun 26, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner June 26, 2024 21:08
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py -k test_positive_verify_updated_fdi_image

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7546
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_discoveredhost.py -k test_positive_verify_updated_fdi_image --external-logging
Test Result : ========== 1 failed, 17 deselected, 26 warnings in 781.03s (0:13:01) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 26, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py -k test_positive_verify_updated_fdi_image

1 similar comment
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_discoveredhost.py -k test_positive_verify_updated_fdi_image

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7574
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_discoveredhost.py -k test_positive_verify_updated_fdi_image --external-logging
Test Result : ========== 1 passed, 17 deselected, 26 warnings in 788.59s (0:13:08) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 28, 2024
Comment on lines +442 to +445
if target_sat.os_version.major == 9:
version = '8.9' if is_open('SAT-25275') else str(target_sat.os_version)
elif target_sat.os_version.major == 8:
version = '8.9' if is_open('SAT-24197') else str(target_sat.os_version)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it makes sense to verify that the incorrect version is present, shouldn't we query for the desired state and use blockedBy to get the test run once the bugs are closed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered this way to verify as there were two different issues for EL8 and EL9, where EL9 isn't expected to be fixed any time soon and EL8 issue is already in-progress but not sure when it'll be ready as well.
And incorrect version is not blocker here it works for both EL8 and EL9 right now, we're just adding this test to verify we build FDI always on latest RHEL, so I wouldn't prefer using blockedBy for this test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block this, but wouldn't this implementation create confusing messages? iiuc the Verifies tag will cause these jiras to get comments that the issue is verified by automation when this test passes, even before they are fixed :) @jameerpathan111 is that right?

Copy link
Contributor

@jameerpathan111 jameerpathan111 Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pondrejk No, unless the issues mentioned byVerifies are in "Review" or "Release Pending" state, the comment for test results won't be added. In other words, by default, it only adds comment if the issue is fixed and is on_qa and not released yet. And as for is_open('SAT-25275'), it doesn't affect the commenting and is unrelated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, fair enough

@Gauravtalreja1 Gauravtalreja1 requested a review from pondrejk July 1, 2024 09:34
@pondrejk pondrejk merged commit d7f9b04 into SatelliteQE:master Jul 4, 2024
17 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 4, 2024
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit d7f9b04)
github-actions bot pushed a commit that referenced this pull request Jul 4, 2024
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit d7f9b04)
github-actions bot pushed a commit that referenced this pull request Jul 4, 2024
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit d7f9b04)
@Gauravtalreja1 Gauravtalreja1 deleted the discovery-24197 branch July 5, 2024 08:49
shubhamsg199 pushed a commit that referenced this pull request Jul 5, 2024
Add test coverage for SAT-24197 (#15521)

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit d7f9b04)

Co-authored-by: Gaurav Talreja <gtalreja@redhat.com>
Gauravtalreja1 added a commit that referenced this pull request Jul 12, 2024
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit d7f9b04)
Gauravtalreja1 added a commit that referenced this pull request Jul 12, 2024
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit d7f9b04)
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants