-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for SAT-24197 #15521
Conversation
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
trigger: test-robottelo |
PRT Result
|
trigger: test-robottelo |
1 similar comment
trigger: test-robottelo |
PRT Result
|
if target_sat.os_version.major == 9: | ||
version = '8.9' if is_open('SAT-25275') else str(target_sat.os_version) | ||
elif target_sat.os_version.major == 8: | ||
version = '8.9' if is_open('SAT-24197') else str(target_sat.os_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it makes sense to verify that the incorrect version is present, shouldn't we query for the desired state and use blockedBy to get the test run once the bugs are closed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered this way to verify as there were two different issues for EL8 and EL9, where EL9 isn't expected to be fixed any time soon and EL8 issue is already in-progress but not sure when it'll be ready as well.
And incorrect version is not blocker here it works for both EL8 and EL9 right now, we're just adding this test to verify we build FDI always on latest RHEL, so I wouldn't prefer using blockedBy for this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to block this, but wouldn't this implementation create confusing messages? iiuc the Verifies tag will cause these jiras to get comments that the issue is verified by automation when this test passes, even before they are fixed :) @jameerpathan111 is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pondrejk No, unless the issues mentioned byVerifies
are in "Review" or "Release Pending" state, the comment for test results won't be added. In other words, by default, it only adds comment if the issue is fixed and is on_qa and not released yet. And as for is_open('SAT-25275')
, it doesn't affect the commenting and is unrelated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, fair enough
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> (cherry picked from commit d7f9b04)
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> (cherry picked from commit d7f9b04)
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> (cherry picked from commit d7f9b04)
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> (cherry picked from commit d7f9b04)
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> (cherry picked from commit d7f9b04)
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Problem Statement
Missing test coverage for SAT-24197, to verify foreman-discovery-image is built on latest up-to-date RHEL
Solution
Add test coverage for SAT-24197, to verify foreman-discovery-image is built on latest up-to-date RHEL
Related Issues