[CV Eval] Test Coverage for ccv interaction with incremental update #15525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambible
added
CherryPick
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
vsedmik
reviewed
Jun 27, 2024
| } | ||
| ) | ||
| # Gives time for the incremental update to finish, and propagate a publish of the composive cv | ||
| time.sleep(2) |
There was a problem hiding this comment.
I can see "Publish CV" task being spawned after incremental update. Should we wait for them to finish instead of the sleep?
Suggested change
| time.sleep(2) | |
| module_target_sat.wait_for_tasks( | |
| search_query=( | |
| f'Actions::Katello::ContentView::Publish and organization_id = {module_org.id}' | |
| ), | |
| max_tries=5, | |
| poll_rate=10, | |
| ) |
There was a problem hiding this comment.
This is definitely a more deterministic way to do this. I'll give it a try. Should be consistent.
|
trigger: test-robottelo |
Satellite-QE
removed
the
PRT-Passed
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
vsedmik
approved these changes
Jun 28, 2024
vsedmik
added
the
AutoMerge_Cherry_Picked
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
…atelliteQE#15525) * CV Eval BZ coverage for ccv inc update * Remove sleep, and instead wait on cv publish task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Adds coverage for https://bugzilla.redhat.com/show_bug.cgi?id=1974225 / https://issues.redhat.com/browse/SATQE-17141
Related Issues
There is one usage of time.sleep(2) - this is to allow the incremental update to propagate, and trigger the CCV publish, but there's probably a better way for this to be done.
PRT test Cases example
trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'test_ccv_inc_update_autopublish'