Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errata::UI test_positive_content_host_previous_env #15548

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Errata::UI test_positive_content_host_previous_env #15548

merged 2 commits into from
Jul 26, 2024

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Jul 2, 2024 •
edited
Loading

Problem Statement

SAT-25213: has been resolved, automation (1 LegacyUI test) is failing now that it is no longer skipped

  • The host setup had a small logic issue (sca manifest org), and was not being updated to use the new_lce,
    so prior env was incorrectly found to be Library instead of module_lce.name
  • Also includes small docstring clarifications, for fixture registered_contenthost
  • Fixed one cli/errata test name from eval, "registerd" to "registered"
trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env

@damoore044 damoore044 added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 2, 2024
@damoore044 damoore044 requested a review from a team as a code owner July 2, 2024 13:40
@damoore044 damoore044 requested a review from a team July 2, 2024 13:40
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7603
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env --external-logging
Test Result : ================== 1 passed, 11 warnings in 807.18s (0:13:27) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 2, 2024
LadislavVasina1
LadislavVasina1 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damoore044 damoore044 force-pushed the legacy_ui_env_dropdown branch from c5f31c1 to 53ea886 Compare July 2, 2024 18:45
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 2, 2024
@pondrejk pondrejk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jul 3, 2024
Gauravtalreja1
Gauravtalreja1 reviewed Jul 3, 2024
View reviewed changes
tests/foreman/ui/test_errata.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_errata.py Outdated Show resolved Hide resolved
@damoore044 damoore044 force-pushed the legacy_ui_env_dropdown branch 2 times, most recently from d53450e to 4767a94 Compare July 3, 2024 14:44
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7632
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env --external-logging
Test Result : ================== 1 failed, 9 warnings in 809.86s (0:13:29) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 3, 2024
@damoore044 damoore044 force-pushed the legacy_ui_env_dropdown branch from 4767a94 to 1bac21d Compare July 3, 2024 15:10
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env

@damoore044 damoore044 force-pushed the legacy_ui_env_dropdown branch from 1bac21d to ab2d96c Compare July 3, 2024 15:34
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7633
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env --external-logging
Test Result : ================== 1 passed, 11 warnings in 830.49s (0:13:50) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 3, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7809
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env --external-logging
Test Result : ================== 1 passed, 13 warnings in 805.79s (0:13:25) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jul 22, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_filtered_errata_status_installable_param

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7810
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_filtered_errata_status_installable_param --external-logging
Test Result : ================== 1 failed, 13 warnings in 927.84s (0:15:27) ==================

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Jul 22, 2024
@damoore044 damoore044 force-pushed the legacy_ui_env_dropdown branch from 4e16678 to 51fd583 Compare July 22, 2024 20:05
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k 'test_positive_content_host_previous_env or test_positive_filtered_errata_status_installable_param'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7814
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py -k test_positive_content_host_previous_env or test_positive_filtered_errata_status_installable_param --external-logging
Test Result : ===== 1 failed, 1 passed, 16 deselected, 110 warnings in 983.72s (0:16:23) =====

@damoore044 damoore044 force-pushed the legacy_ui_env_dropdown branch from 51fd583 to 1930b37 Compare July 22, 2024 23:22
@damoore044 damoore044 force-pushed the legacy_ui_env_dropdown branch from 1930b37 to 1e4c0ce Compare July 23, 2024 13:11
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7818
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env --external-logging
Test Result : ================== 1 passed, 13 warnings in 762.40s (0:12:42) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jul 23, 2024
@damoore044
Copy link
Contributor Author

Removed small change to params order of local helper cv_publish_promote.
Args were being mismatched, so just kept docstring additions.

Only test_positive_content_host_previous_env has been modified,
and the name of one cli test was corrected, test_install_applicable_package_to_registered_host, which passes in CI.

@damoore044 damoore044 force-pushed the legacy_ui_env_dropdown branch from e7b4c20 to 391aa52 Compare July 23, 2024 14:28
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 23, 2024
@damoore044 damoore044 added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 23, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7829
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py::test_positive_content_host_previous_env --external-logging
Test Result : ================== 1 passed, 13 warnings in 785.34s (0:13:05) ==================

@vsedmik vsedmik merged commit 6f5aa44 into SatelliteQE:master Jul 26, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
@damoore044 @web-flow
Errata::UI test_positive_content_host_previous_env (#15548)
d64db2d 
* ui::previous_env fixes for prior env's name

* rmv failing changes to helper method params

(cherry picked from commit 6f5aa44)
@Satellite-QE Satellite-QE mentioned this pull request Jul 26, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@damoore044 @jyejare
Errata::UI test_positive_content_host_previous_env (SatelliteQE#15548)
535f44e 
* ui::previous_env fixes for prior env's name

* rmv failing changes to helper method params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@pondrejk pondrejk pondrejk approved these changes

@Gauravtalreja1 Gauravtalreja1 Awaiting requested review from Gauravtalreja1

Assignees

@damoore044 damoore044

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@damoore044 @Satellite-QE @pondrejk @Gauravtalreja1 @ColeHiggins2 @vijaysawant @vsedmik @LadislavVasina1