Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-existing ansible modules #15549

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Remove non-existing ansible modules #15549

merged 1 commit into from
Jul 2, 2024

Conversation

Griffin-Sullivan
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan commented Jul 2, 2024 •
edited
Loading

Problem Statement

These parametrize into our FAM tests but don't actually exist. Not sure how they got copied over.

Solution

Remove them since they are not real modules.

Related Issues

Note: This doesn't really need any testing, it will just no longer parametrize these.

@Griffin-Sullivan Griffin-Sullivan requested a review from a team as a code owner July 2, 2024 15:47
@Griffin-Sullivan Griffin-Sullivan added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 2, 2024
vijaysawant
vijaysawant approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like these changes are part of this PR #14028.

@Griffin-Sullivan
Copy link
Contributor Author

Look like these changes are part of this PR #14028.

Yeah I remember making the change I just don't remember how I created the list of modules lol

@Griffin-Sullivan Griffin-Sullivan added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jul 2, 2024
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: -vv tests/foreman/sys/test_fam.py::test_positive_run_modules_and_roles

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7606
Build Status: UNSTABLE
PRT Comment: pytest -vv tests/foreman/sys/test_fam.py::test_positive_run_modules_and_roles --external-logging
Test Result : =========== 57 failed, 51 passed, 247 warnings in 3266.08s (0:54:26) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 2, 2024
@Griffin-Sullivan
Copy link
Contributor Author

You can see in the PRT build above that the two lines I removed were not run as parameters. So we are good to go.

@Gauravtalreja1 Gauravtalreja1 added the Easy Fix :) Easiest Fix to review and quick merge request. label Jul 2, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 1ad9d6a into SatelliteQE:master Jul 2, 2024
13 of 15 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
@Griffin-Sullivan @web-flow
Remove non-existing ansible modules (#15549)
c01bdd8 
(cherry picked from commit 1ad9d6a)
github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
@Griffin-Sullivan @web-flow
Remove non-existing ansible modules (#15549)
a49fcd6 
(cherry picked from commit 1ad9d6a)
This was referenced Jul 2, 2024
Closed
Merged
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Jul 3, 2024
@Satellite-QE @Griffin-Sullivan
[6.15.z] Remove non-existing ansible modules (#15552)
a43390a 
Remove non-existing ansible modules (#15549)

(cherry picked from commit 1ad9d6a)

Co-authored-by: Griffin Sullivan <48397354+Griffin-Sullivan@users.noreply.github.com>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 3, 2024
@Satellite-QE @Griffin-Sullivan
[6.14.z] Remove non-existing ansible modules (#15553)
f2d2e3a 
Remove non-existing ansible modules (#15549)

(cherry picked from commit 1ad9d6a)

Co-authored-by: Griffin Sullivan <48397354+Griffin-Sullivan@users.noreply.github.com>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Griffin-Sullivan @jyejare
Remove non-existing ansible modules (SatelliteQE#15549)
d393e3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

Assignees

@Griffin-Sullivan Griffin-Sullivan

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Griffin-Sullivan @Gauravtalreja1 @Satellite-QE @vijaysawant