Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team Codeowners and Phoenix has more files #15578

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Team Codeowners and Phoenix has more files #15578

merged 2 commits into from
Jul 8, 2024

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Jul 5, 2024 •
edited
Loading

Problem Statement

  • Teams are now T1 Reviewers and hence they should have notification for the file changes made in their own team test file.
  • Tier1 Reviewer are optional and hence are not going to be getting notification.
  • Phoenix team looks to have more files.

Solution

  • Codeowners file is updated with per test file ownership per team.
  • Team Phoenix files are updated.

Related Issues

@jyejare jyejare requested a review from a team as a code owner July 5, 2024 07:52
@jyejare jyejare added the No-CherryPick PR doesnt need CherryPick to previous branches label Jul 5, 2024
@jyejare jyejare changed the title Team Codeowners Team Codeowners and Phoenix has more files Jul 5, 2024
shweta83
shweta83 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for Rocket team components.

@jyejare
Copy link
Member Author

jyejare commented Jul 8, 2024

@vsedmik @pondrejk Please review.

vsedmik
vsedmik approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one note - should we keep the original /tests/foreman/virtwho/ @SatelliteQE/phoenix, since everything in that folder falls under Phoenix?

@jyejare jyejare force-pushed the team_codeowners branch from 22d3409 to b731447 Compare July 8, 2024 10:12
@jyejare
Copy link
Member Author

jyejare commented Jul 8, 2024

@vsedmik Thanks for the review, changes are now updated.

@jyejare
Copy link
Member Author

jyejare commented Jul 8, 2024

All 4 ACKs from QEPOCs lets me merge this to production now.

@jyejare jyejare merged commit affc9f1 into SatelliteQE:master Jul 8, 2024
8 checks passed
jyejare added a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@jyejare
Team Codeowners and Phoenix has more files (SatelliteQE#15578)
6c34ae9 
* Team Codeowners

* Adding more test modules to Phoenix list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@shweta83 shweta83 shweta83 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

Assignees

@jyejare jyejare

Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jyejare @pondrejk @shweta83 @vsedmik @Griffin-Sullivan