removing attach and auto-attach related items from cli hosts #15607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synkd
requested changes
Jul 9, 2024
tests/foreman/cli/test_host.py
Outdated
| @@ -2216,7 +1912,6 @@ def test_positive_unregister_host_subscription( | |||
| res = rhel_contenthost.register(module_org, None, ak_with_subscription.name, target_sat) | |||
There was a problem hiding this comment.
Do we still need this test? If so, shouldn't the activation key be one without subscriptions?
| @pytest.mark.rhel_ver_match('7') | ||
| @pytest.mark.cli_host_subscription | ||
| @pytest.mark.tier3 | ||
| def test_negative_without_attach_with_lce( |
There was a problem hiding this comment.
This still seems like a valid test case to me, although I think it should be renamed to a positive test for 6.16+. Can you please explain your decision to remove it?
There was a problem hiding this comment.
makes sense, I brought it back with updated name
|
@pondrejk Do you really need Tier2 review here ? |
|
I'd guess no because this is a test change, not a framework change? |
pondrejk
force-pushed
the
no-attach-hosts
branch
3 times, most recently
from
ef4ac3a to
22698f6
Compare
pondrejk
force-pushed
the
no-attach-hosts
branch
from
22698f6 to
b940cfe
Compare
|
@synkd Hi, sorry for delay, mind revisiting? |
synkd
approved these changes
Aug 1, 2024
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
these tests no longer apply to 6.16 environment