Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA- merge repo cli test scenarios, ansible collection repo sync and export #15621

Merged

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Jul 10, 2024

Problem Statement

Component audit - SAT-23366
Merge 2 related scenarios

Solution

Merged into test_positive_export_ansible_collection
Removed testcase test_positive_sync_ansible_collection
Updated testcase name test_positive_sync_and_export_ansible_collection

Related Issues

NA

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py -k 'test_positive_sync_and_export_ansible_collection'

Note:
As per comment from @vsedmik updating file as export and import scenario is already covered in ISS tests

@vijaysawant vijaysawant added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jul 10, 2024
@vijaysawant vijaysawant force-pushed the 7-SAT-23366-repo-sync-and-export branch from 686405d to c79d8e9 Compare July 10, 2024 18:25
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py -k 'test_positive_sync_and_export_ansible_collection'

@vijaysawant vijaysawant reopened this Jul 10, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py -k 'test_positive_sync_and_export_ansible_collection'

@vijaysawant vijaysawant marked this pull request as ready for review July 10, 2024 18:28
@vijaysawant vijaysawant requested a review from a team as a code owner July 10, 2024 18:28
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7707
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_repository.py -k test_positive_sync_and_export_ansible_collection --external-logging
Test Result : ========= 2 passed, 133 deselected, 166 warnings in 754.20s (0:12:34) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 10, 2024
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should keep the sync test for the sake of testing it in the Repositories component and let the export (and import) be tested in the ISS component where it actually belongs. We have coverage for export and import already:

def test_postive_export_import_ansible_collection_repo(

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 11, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7709
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_repository.py::TestAnsibleCollectionRepository::test_positive_sync_ansible_collection --external-logging
Test Result : ================== 2 passed, 36 warnings in 657.68s (0:10:57) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 11, 2024
@vijaysawant vijaysawant requested a review from vsedmik July 11, 2024 08:17
@omkarkhatavkar omkarkhatavkar merged commit 6865194 into SatelliteQE:master Jul 11, 2024
11 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
…xport (SatelliteQE#15621)

* CA-sync and export ansible collection repos

* addressed review comment and keeping only on scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants