Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle int type conf key for dynaconf ipv6 migration #15630

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Jul 11, 2024

Problem Statement

  • Confs having integer type setting complaints when migrating all the settings that contain Ipv4 string to convert to Ipv6 even though the int setting does not have Ipv4 containing value .

Stacktrace:

dotted_settings = '.'.join(setting_major)
for _key, _val in settings_list.items():

TypeError: sequence item 6: expected str instance, int found

Solution

  • Altering the settings to string just when setting the converted value which should not change the type of any integer setting.

Related Issues and Description

@jyejare jyejare requested a review from a team as a code owner July 11, 2024 14:53
@jyejare jyejare self-assigned this Jul 11, 2024
@jyejare jyejare added 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. labels Jul 11, 2024
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@JacobCallahan JacobCallahan merged commit a104d42 into SatelliteQE:master Jul 11, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
jyejare added a commit that referenced this pull request Jul 12, 2024
Handle int type conf key for dynaconf ipv6 migration (#15630)

(cherry picked from commit a104d42)

Co-authored-by: Jitendra Yejare <jyejare@redhat.com>
jyejare added a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants