Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated assertions for HTTP Proxy CLI #15646

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jul 12, 2024

Problem Statement

Product update with HTTP proxy now runs Actions::Katello::Repository::Update synchronously - shows the "dot progress bar" instead of printing 'Product proxy updated' message and running the task async as we are used to in previous versions.

[root@sat ~]# hammer product update-proxy --ids=5,6 --http-proxy-policy='use_selected_http_proxy' --http-proxy-id=2
[..........................................................................................................] [100%]
[root@sat ~]# 

Solution

Remove the assertion for that message and just keep testing the result.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py -k test_positive_assign_http_proxy_to_products

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jul 12, 2024
@vsedmik vsedmik self-assigned this Jul 12, 2024
@vsedmik vsedmik requested a review from a team as a code owner July 12, 2024 12:27
@vsedmik
Copy link
Contributor Author

vsedmik commented Jul 12, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py -k test_positive_assign_http_proxy_to_product

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7727
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_http_proxy.py -k test_positive_assign_http_proxy_to_product --external-logging
Test Result : =========== 1 passed, 8 deselected, 17 warnings in 834.20s (0:13:54) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 12, 2024
@@ -264,14 +264,13 @@ def test_positive_assign_http_proxy_to_products(module_org, module_target_sat):
)

# Set the HTTP proxy through bulk action for both products to the selected proxy
res = module_target_sat.cli.Product.update_proxy(
module_target_sat.cli.Product.update_proxy(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what stdout do we get now when running product update_proxy in CLI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like stdout for the update_proxy CLI command is now the progress bar shown in the problem statement above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the res.stdout was None (not even the progress bar).

@jameerpathan111 jameerpathan111 merged commit f6b46f5 into SatelliteQE:master Jul 16, 2024
11 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants