-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated assertions for HTTP Proxy CLI #15646
Conversation
trigger: test-robottelo |
PRT Result
|
@@ -264,14 +264,13 @@ def test_positive_assign_http_proxy_to_products(module_org, module_target_sat): | |||
) | |||
|
|||
# Set the HTTP proxy through bulk action for both products to the selected proxy | |||
res = module_target_sat.cli.Product.update_proxy( | |||
module_target_sat.cli.Product.update_proxy( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what stdout do we get now when running product update_proxy in CLI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like stdout for the update_proxy CLI command is now the progress bar shown in the problem statement above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC the res.stdout
was None
(not even the progress bar).
Remove deprecated assertions
Problem Statement
Product update with HTTP proxy now runs
Actions::Katello::Repository::Update
synchronously - shows the "dot progress bar" instead of printing 'Product proxy updated' message and running the task async as we are used to in previous versions.Solution
Remove the assertion for that message and just keep testing the result.
PRT test Cases example
trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py -k test_positive_assign_http_proxy_to_products