Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAM: don't set a password for auth_source_ldap tests #15647

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 12, 2024

Problem Statement

the password field is protected, so the API doesn't return it and thus we always detect a change, failing tests

Solution

don't set the password field

Related Issues

the password field is protected, so the API doesn't return it and thus
we always detect a change, failing tests
@evgeni evgeni requested a review from a team as a code owner July 12, 2024 12:49
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
@Griffin-Sullivan Can you please add the desired labels and merge the PR?

@Griffin-Sullivan Griffin-Sullivan added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 15, 2024
@Griffin-Sullivan Griffin-Sullivan merged commit c390a27 into SatelliteQE:master Jul 15, 2024
11 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 15, 2024
the password field is protected, so the API doesn't return it and thus
we always detect a change, failing tests

(cherry picked from commit c390a27)
github-actions bot pushed a commit that referenced this pull request Jul 15, 2024
the password field is protected, so the API doesn't return it and thus
we always detect a change, failing tests

(cherry picked from commit c390a27)
@evgeni evgeni deleted the no-password-fam branch July 15, 2024 13:47
Gauravtalreja1 pushed a commit that referenced this pull request Jul 15, 2024
FAM: don't set a password for auth_source_ldap tests (#15647)

the password field is protected, so the API doesn't return it and thus
we always detect a change, failing tests

(cherry picked from commit c390a27)

Co-authored-by: Evgeni Golov <evgeni@golov.de>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 15, 2024
FAM: don't set a password for auth_source_ldap tests (#15647)

the password field is protected, so the API doesn't return it and thus
we always detect a change, failing tests

(cherry picked from commit c390a27)

Co-authored-by: Evgeni Golov <evgeni@golov.de>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
the password field is protected, so the API doesn't return it and thus
we always detect a change, failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants