Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PIT marker for repositories test #15655

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Jul 15, 2024

Problem Statement

PIT marker missing for repositories component.

Solution

This PR changes

Related Issues

Proposing new default_rhel_version, changes made into the gitlab MR-1413

@vijaysawant vijaysawant requested a review from ogajduse July 15, 2024 09:04
@vijaysawant vijaysawant requested a review from a team as a code owner July 15, 2024 09:04
@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 15, 2024
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the patch, but please remember that the test is fixed to use RHEL 9. That means when the client scenario is triggered by RHEL 10 compose being out, pytest will not pick this test due to the hard-code.

If you want to make any changes now, I would recommend using @pytest.mark.rhel_ver_list([settings.content_host.default_rhel_version]) to pin the test to exactly one RHEL version specified in the settings. It is currently RHEL 8, but that could eventually be changed to RHEL 9 if the team agrees. Feel free to propose a config change. In the PIT client automation pipeline, we are changing this constant to the RHEL version under test.

@vijaysawant
Copy link
Contributor Author

I am fine with the patch, but please remember that the test is fixed to use RHEL 9. That means when the client scenario is triggered by RHEL 10 compose being out, pytest will not pick this test due to the hard-code.

If you want to make any changes now, I would recommend using @pytest.mark.rhel_ver_list([settings.content_host.default_rhel_version]) to pin the test to exactly one RHEL version specified in the settings. It is currently RHEL 8, but that could eventually be changed to RHEL 9 if the team agrees. Feel free to propose a config change. In the PIT client automation pipeline, we are changing this constant to the RHEL version under test.

In order to propose new value (default_rhel_version: 9) what other changes are require in the yaml file?
@ogajduse

@vijaysawant
Copy link
Contributor Author

I am fine with the patch, but please remember that the test is fixed to use RHEL 9. That means when the client scenario is triggered by RHEL 10 compose being out, pytest will not pick this test due to the hard-code.
If you want to make any changes now, I would recommend using @pytest.mark.rhel_ver_list([settings.content_host.default_rhel_version]) to pin the test to exactly one RHEL version specified in the settings. It is currently RHEL 8, but that could eventually be changed to RHEL 9 if the team agrees. Feel free to propose a config change. In the PIT client automation pipeline, we are changing this constant to the RHEL version under test.

In order to propose new value (default_rhel_version: 9) what other changes are require in the yaml file? @ogajduse

I guess nothing apart from that rhel_major_version

@ogajduse
Copy link
Member

ogajduse commented Jul 16, 2024

Nothing apart from the default_rhel_version config needs to be changed.

Edit: Of course, assuming you use the setting in the rhel_ver_list marker.

@ogajduse ogajduse merged commit 725740f into SatelliteQE:master Jul 16, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
jameerpathan111 pushed a commit that referenced this pull request Jul 16, 2024
add PIT marker for repositories test (#15655)

(cherry picked from commit 725740f)

Co-authored-by: vijay sawant <vijaysawant36@gmail.com>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants