[RHCloud]Adding PIT markers for interop #15666
Conversation
tests/foreman/api/test_rhc.py
Outdated
| @pytest.mark.pit_server | ||
| @pytest.mark.pit_client |
There was a problem hiding this comment.
As per my understanding,
In order to use pit_server & pit_client marker test should satiesfy some conditions
server tests will contains- non destructive, not fips
client tests will contains- `--no-containers` marker, not fips
- If we look this test, it uses
destructivemarker, we can't usepit_servermarker here. - Talking about
pit_clientscenario, so test doesn't have anything related to rhel content host, good to remove client marker.
There was a problem hiding this comment.
One small correction, --no-containers is a parameter that controls whether content hosts will be containers or VMs. If the test is already marked with @pytest.mark.no_containers, that is fine. In the PIT pipeline, we force all tests to run on VM by using --no-containers as a pytest argument.
| @@ -30,6 +30,8 @@ def create_insights_vulnerability(insights_vm): | |||
|
|
|||
|
|
|||
| @pytest.mark.e2e | |||
| @pytest.mark.pit_server | |||
| @pytest.mark.pit_client | |||
| @pytest.mark.tier3 | |||
| @pytest.mark.no_containers | |||
| @pytest.mark.rhel_ver_list([7, 8, 9]) | |||
There was a problem hiding this comment.
Just to let you know, this test will not be picked up in RHEL 10 testing. That is future™ at the moment, but either keep that in mind or change rhel_ver_list([7, 8, 9]) to rhel_ver_match(r'^[\d]+$')
https://regex101.com/r/iIRpTO/1
That ensures that FIPS hosts will not be used, but RHEL 10 + will be.
The same applies to test_insights_registration_with_capsule below.
tests/foreman/api/test_rhc.py
Outdated
| @pytest.mark.pit_server | ||
| @pytest.mark.pit_client |
There was a problem hiding this comment.
One small correction, --no-containers is a parameter that controls whether content hosts will be containers or VMs. If the test is already marked with @pytest.mark.no_containers, that is fine. In the PIT pipeline, we force all tests to run on VM by using --no-containers as a pytest argument.
| @@ -300,6 +302,8 @@ def test_host_details_page( | |||
|
|
|||
|
|
|||
| @pytest.mark.e2e | |||
| @pytest.mark.pit_server | |||
There was a problem hiding this comment.
Marking this test with pit_server might be an issue since our internal infra does not have an install-capsule-on-top-of-rhel-compose workflow defined. We need to define that workflow first and also make sure that our PIT pipeline script changes the capsule config as desired.
Without this workflow, the capsule would be installed on top of the GA'd RHEL version instead of the RHEL version that we are supposed to test on.
Hit me up on Slack, I can guide you.
|
If you wish the newly marked tests to be picked up also in 6.13 and 6.14 PIT testing, please add the respective labels. |
ColeHiggins2
force-pushed
the
rhcloud-pit-markers
branch
from
3037a5e to
ac3810f
Compare
sambible
added
CherryPick
* Adding pit marker for tests * updating and removing incorrect markers --------- Co-authored-by: Samuel Bible <sbible@redhat.com> (cherry picked from commit 428237e)
* Adding pit marker for tests * updating and removing incorrect markers --------- Co-authored-by: Samuel Bible <sbible@redhat.com>
Adding PIT markers for RHCloud