Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jira comments based on Jira labels #15686

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add jira comments based on Jira labels #15686

merged 2 commits into from
Jul 22, 2024

Conversation

jameerpathan111
Copy link
Contributor

Problem Statement

  • Reduce the frequency of commenting test results on Jira.

Solution

Take action based on labels

  • Initially set a Pass/Fail label based on the test result
  • If the state changes add a comment
  • If the state is already failing, and test is failing, still add a comment
  • If the state is already passing, and the test passes, don’t add a comment

Related Issues

  • SAT-26505 and SAT-26504

@jameerpathan111 jameerpathan111 added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 17, 2024
@jameerpathan111 jameerpathan111 self-assigned this Jul 17, 2024
@jameerpathan111 jameerpathan111 requested a review from a team as a code owner July 17, 2024 14:48
@jameerpathan111 jameerpathan111 mentioned this pull request Jul 17, 2024
Merged
JacobCallahan
JacobCallahan requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change needed

pytest_plugins/jira_comments.py Outdated Show resolved Hide resolved
jyejare
jyejare approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACKed the commints in another commit with some non-blocking questions. The commits would be rebased in that PR later.

@jyejare jyejare merged commit 9922d1f into SatelliteQE:master Jul 22, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@jameerpathan111 @web-flow
Add jira comments based on Jira labels (#15686)
bb1ac63 
* Add support for updating Jira labels

* Add Jira comment only when there are test failures

(cherry picked from commit 9922d1f)
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@jameerpathan111 @web-flow
Add jira comments based on Jira labels (#15686)
2d0eefd 
* Add support for updating Jira labels

* Add Jira comment only when there are test failures

(cherry picked from commit 9922d1f)
@Satellite-QE Satellite-QE mentioned this pull request Jul 22, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@jameerpathan111 @web-flow
Add jira comments based on Jira labels (#15686)
7af9144 
* Add support for updating Jira labels

* Add Jira comment only when there are test failures

(cherry picked from commit 9922d1f)
This was referenced Jul 22, 2024
Merged
Merged
Merged
Merged
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@jameerpathan111 @jyejare
Add jira comments based on Jira labels (SatelliteQE#15686)
b612854 
* Add support for updating Jira labels

* Add Jira comment only when there are test failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@jameerpathan111 jameerpathan111

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameerpathan111 @JacobCallahan @jyejare