Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for host multi-CV #15688

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

jeremylenz
Copy link
Contributor

@jeremylenz jeremylenz commented Jul 17, 2024

Problem Statement

There is no test coverage for existing features around multi-CV.

Solution

Add tests covering existing functionality. This PR adds the first test, covering the downstream Setting that is not exposed.

@jeremylenz jeremylenz requested review from a team as code owners July 17, 2024 18:36
@omkarkhatavkar
Copy link

Can one of the admins verify this patch?

@jeremylenz jeremylenz force-pushed the multi-cv-tests branch 2 times, most recently from a72b768 to c72cba9 Compare July 17, 2024 18:41
@ColeHiggins2
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_multi_cv_reg_not_allowed'

@ColeHiggins2 ColeHiggins2 added RFE Issues that are requesting an enhancement to robottelo No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jul 18, 2024
@ColeHiggins2
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_multi_cv_reg_not_allowed

tests/foreman/cli/test_host.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_host.py Show resolved Hide resolved
tests/foreman/cli/test_host.py Show resolved Hide resolved
tests/foreman/cli/test_host.py Show resolved Hide resolved
@jeremylenz jeremylenz force-pushed the multi-cv-tests branch 2 times, most recently from 2acc933 to b9ce6fd Compare July 18, 2024 17:04
@jeremylenz
Copy link
Contributor Author

@ColeHiggins2 Rebased and comments should be addressed now. Also added an assertion that the setting is not exposed.

@jeremylenz jeremylenz requested a review from ColeHiggins2 July 18, 2024 17:04
@jeremylenz
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_multi_cv_reg_not_allowed'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7775
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_multi_cv_reg_not_allowed --external-logging
Test Result : ========== 2 passed, 94 deselected, 128 warnings in 843.63s (0:14:03) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 18, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 18, 2024
tests/foreman/cli/test_host.py Outdated Show resolved Hide resolved
@jeremylenz
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_negative_multi_cv_registration'

@jeremylenz jeremylenz requested a review from ColeHiggins2 July 18, 2024 17:40
@jeremylenz jeremylenz changed the title Add tests for host multi-CV Add test for host multi-CV Jul 18, 2024
@jeremylenz
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_negative_multi_cv_registration'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7776
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_negative_multi_cv_registration --external-logging
Test Result : ========== 2 passed, 94 deselected, 129 warnings in 761.28s (0:12:41) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 18, 2024
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7777
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_negative_multi_cv_registration --external-logging
Test Result : ========== 2 passed, 94 deselected, 130 warnings in 802.65s (0:13:22) ==========

@jyejare jyejare merged commit 21b5935 into SatelliteQE:master Jul 19, 2024
10 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR RFE Issues that are requesting an enhancement to robottelo Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants