Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV formatting fixes #15689

Merged
merged 1 commit into from
Aug 1, 2024
Merged

CSV formatting fixes #15689

merged 1 commit into from
Aug 1, 2024

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Jul 17, 2024 •
edited
Loading

Problem Statement

Previously, CLI commands run with hammer --output csv [COMMAND] would in some cases return non-CSV output. Over time, robottelo's parse_csv method developed several workarounds to handle these bugs.

Solution

This PR removes all of the workaround code from parse_csv, as all of the corresponding issues are fixed as of Satellite 6.16.

Related Issues

SAT-26483

@tpapaioa tpapaioa added CLI Issues and PRs involving the CLI CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 17, 2024
@tpapaioa tpapaioa self-assigned this Jul 17, 2024
@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 17, 2024
@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Jul 18, 2024
@tpapaioa tpapaioa added Bug This is an issue with the robottelo framework in progress This issue is being worked on No-CherryPick PR doesnt need CherryPick to previous branches Do Not Merge and removed CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 29, 2024
@tpapaioa tpapaioa force-pushed the csv_fixes branch 3 times, most recently from 3847b19 to 533d313 Compare July 30, 2024 18:14
@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Jul 30, 2024
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_install_package_via_rex[rhel8] tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/ tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_positive_run_packages_and_services_job[rhel8]

@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Jul 31, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Jul 31, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Jul 31, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Jul 31, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7929
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_install_package_via_rex[rhel8] tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/ tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_positive_run_packages_and_services_job[rhel8] --external-logging
Test Result : ================= 3 passed, 144 warnings in 1423.27s (0:23:43) =================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jul 31, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 31, 2024
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_install_package_via_rex[rhel8] tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_positive_run_packages_and_services_job[rhel8]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7930
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_install_package_via_rex[rhel8] tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_positive_run_packages_and_services_job[rhel8] --external-logging
Test Result : ================= 3 passed, 141 warnings in 1444.17s (0:24:04) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 31, 2024
@tpapaioa tpapaioa removed Bug This is an issue with the robottelo framework in progress This issue is being worked on Do Not Merge labels Jul 31, 2024
@tpapaioa tpapaioa marked this pull request as ready for review July 31, 2024 17:24
@tpapaioa tpapaioa requested review from a team as code owners July 31, 2024 17:24
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 31, 2024
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_install_package_via_rex[rhel8] tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_positive_run_packages_and_services_job[rhel8]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7932
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_install_package_via_rex[rhel8] tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_positive_run_packages_and_services_job[rhel8] --external-logging
Test Result : ================= 3 passed, 138 warnings in 1425.93s (0:23:45) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 31, 2024
ogajduse
ogajduse approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks rock solid, Tasos.
Co-reviewed with @rplevka.

@ogajduse ogajduse merged commit 6356ee4 into SatelliteQE:master Aug 1, 2024
11 checks passed
@tpapaioa tpapaioa deleted the csv_fixes branch August 1, 2024 13:51
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@tpapaioa @jyejare
CSV formatting fixes (SatelliteQE#15689)
9c7e087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rplevka rplevka rplevka approved these changes

@ogajduse ogajduse ogajduse approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

Assignees

@tpapaioa tpapaioa

Labels
CLI Issues and PRs involving the CLI No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tpapaioa @Satellite-QE @rplevka @ogajduse @ColeHiggins2