Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for chronyd install and timesource option for RHEL9 in rendered template #15700

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add check for chronyd install and timesource option for RHEL9 in rendered template #15700

merged 1 commit into from
Jul 22, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Jul 19, 2024 •
edited
Loading

Problem Statement

ntp uses chronyd instead of ntpdate which is deprecated.
RHEL9 uses timesource when ntp-server host param is used.

Solution

Added a check to verify chronyd is getting installed in rendered template
Added a check for timesource option in rendered template

Related Issues

@shweta83 shweta83 requested a review from a team as a code owner July 19, 2024 04:56
@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 QETestCoverage Issues and PRs relating to a Satellite bug labels Jul 19, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py -k test_positive_template_check_rex_pull_mode_snippet

@shweta83 shweta83 force-pushed the provisioningtemplate_update branch 2 times, most recently from 16e124b to 74c9db3 Compare July 19, 2024 07:08
@shweta83 shweta83 changed the title Add check for chronyd install in rendered template Add check for chronyd install and timesource option for RHEL9 in rendered template Jul 19, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py -k 'test_positive_template_check_rex_pull_mode_snippet or test_positive_template_check_rex_snippet'

@shweta83 shweta83 force-pushed the provisioningtemplate_update branch 2 times, most recently from a01c33e to 18f176c Compare July 19, 2024 08:03
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py -k test_positive_verify_chronyd_timesource_kickstart_template

@shweta83 shweta83 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master and removed CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Jul 19, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7788
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py -k test_positive_verify_chronyd_timesource_kickstart_template --external-logging
Test Result : ========= 3 passed, 28 deselected, 133 warnings in 1122.20s (0:18:42) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 19, 2024
@shweta83 shweta83 requested a review from Gauravtalreja1 July 19, 2024 11:16
Gauravtalreja1
Gauravtalreja1 reviewed Jul 19, 2024
View reviewed changes
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
tests/foreman/api/test_provisioningtemplate.py Outdated Show resolved Hide resolved
@shweta83 shweta83 force-pushed the provisioningtemplate_update branch from 18f176c to 782d604 Compare July 22, 2024 08:09
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 22, 2024
@shweta83 shweta83 requested a review from Gauravtalreja1 July 22, 2024 08:10
@shweta83 shweta83 force-pushed the provisioningtemplate_update branch 3 times, most recently from eff2257 to 2322ade Compare July 22, 2024 09:00
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py -k test_positive_verify_chronyd_timesource_kickstart_template

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7806
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py -k test_positive_verify_chronyd_timesource_kickstart_template --external-logging
Test Result : ========== 3 passed, 28 deselected, 118 warnings in 794.66s (0:13:14) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 22, 2024
@shweta83 shweta83 force-pushed the provisioningtemplate_update branch from 2322ade to 5d11452 Compare July 22, 2024 09:47
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 22, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py -k test_positive_verify_chronyd_timesource_kickstart_template

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7807
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py -k test_positive_verify_chronyd_timesource_kickstart_template --external-logging
Test Result : ========== 3 passed, 28 deselected, 118 warnings in 765.45s (0:12:45) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 22, 2024
@Gauravtalreja1 Gauravtalreja1 enabled auto-merge (squash) July 22, 2024 10:27
@Gauravtalreja1 Gauravtalreja1 merged commit 2907399 into SatelliteQE:master Jul 22, 2024
11 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shweta83 @jyejare
Add check for chronyd install and timesource option for RHEL9 in rend…
5beefe1 
…ered template (SatelliteQE#15700)

Add check for chronyd install in rendered template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shweta83 shweta83

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shweta83 @Satellite-QE @Gauravtalreja1