Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for VMware image based provisioning #15733

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Add test for VMware image based provisioning #15733

merged 1 commit into from
Aug 2, 2024

Conversation

shubhamsg199
Copy link
Contributor

@shubhamsg199 shubhamsg199 commented Jul 23, 2024 •
edited
Loading

Component Audit: Adding a test for VMware image based provisioning

Dependent Nailgun PR: SatelliteQE/nailgun#1204

@shubhamsg199 shubhamsg199 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 23, 2024
@shubhamsg199 shubhamsg199 self-assigned this Jul 23, 2024
@shubhamsg199 shubhamsg199 requested review from a team as code owners July 23, 2024 12:41
@shubhamsg199 shubhamsg199 marked this pull request as draft July 23, 2024 12:45
@shubhamsg199 shubhamsg199 marked this pull request as ready for review July 24, 2024 15:45
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true
pod_resources_size: extra_extra_large

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7842
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 26 deselected, 54 warnings, 2 errors in 1484.48s (0:24:44) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 24, 2024
@shubhamsg199 shubhamsg199 mentioned this pull request Jul 24, 2024
Merged
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
nailgun: 1204
provisioning: true
pod_resources_size: extra_extra_large

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7844
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 passed, 26 deselected, 60 warnings in 2133.99s (0:35:33) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jul 24, 2024
Gauravtalreja1
Gauravtalreja1 reviewed Jul 25, 2024
View reviewed changes
tests/foreman/cli/test_computeresource_vmware.py Show resolved Hide resolved
tests/foreman/cli/test_computeresource_vmware.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_computeresource_vmware.py Show resolved Hide resolved
pytest_fixtures/component/provision_vmware.py Outdated
architecture=default_architecture,
compute_resource=module_vmware_cr,
name=gen_string('alpha'),
operatingsystem=module_provisioning_rhel_content.os,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've only EL8 image in this CR, so can we use that dynaconf setting here instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you meant here, but if you're saying using image_os from settings , it won't work as this is api image creation and need OS object

Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 Jul 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I get it, but isn't it possible to create the OS object from it by searching and use here instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@shubhamsg199 shubhamsg199 force-pushed the vmware-image-based-provisioning branch from b93ed3d to 9aebb59 Compare July 25, 2024 17:30
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 25, 2024
@shubhamsg199 shubhamsg199 force-pushed the vmware-image-based-provisioning branch from 9aebb59 to 344b91b Compare July 25, 2024 17:33
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
nailgun: 1204
provisioning: true
pod_resources_size: extra_extra_large

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7864
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 passed, 26 deselected, 59 warnings in 1780.67s (0:29:40) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 25, 2024
@shubhamsg199 shubhamsg199 force-pushed the vmware-image-based-provisioning branch from 344b91b to 44c52df Compare July 26, 2024 15:50
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 26, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
nailgun: 1204
provisioning: true
pod_resources_size: extra_extra_large

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7879
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 passed, 26 deselected, 61 warnings in 1781.93s (0:29:41) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 26, 2024
This was referenced Jul 29, 2024
Merged
Merged
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7891
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 26 deselected, 56 warnings, 2 errors in 1505.64s (0:25:05) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 29, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7892
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 26 deselected, 55 warnings, 2 errors in 1809.28s (0:30:09) ==========

@shubhamsg199 shubhamsg199 force-pushed the vmware-image-based-provisioning branch from 4800c94 to f784a37 Compare July 29, 2024 18:09
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end
provisioning: true
pod_resources_size: extra_extra_large

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7894
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_computeresource_vmware.py -k test_positive_image_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 2 passed, 26 deselected, 62 warnings in 1728.34s (0:28:48) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jul 29, 2024
@Gauravtalreja1 Gauravtalreja1 force-pushed the vmware-image-based-provisioning branch from f784a37 to 8a946d2 Compare July 29, 2024 20:02
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 29, 2024
ColeHiggins2
ColeHiggins2 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending pre-commit failures...

Lets run:
pre-commit run --all-files on your branch and repush

@shubhamsg199
VMware image based provisioning
ffa0b24 
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
@shubhamsg199 shubhamsg199 force-pushed the vmware-image-based-provisioning branch from 8a946d2 to ffa0b24 Compare July 31, 2024 13:19
@Gauravtalreja1 Gauravtalreja1 added the QETestCoverage Issues and PRs relating to a Satellite bug label Aug 2, 2024
@Gauravtalreja1 Gauravtalreja1 enabled auto-merge (squash) August 2, 2024 08:29
@Gauravtalreja1 Gauravtalreja1 merged commit 0f24a56 into SatelliteQE:master Aug 2, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
@shubhamsg199 @web-flow
Add test for VMware image based provisioning (#15733)
a01f5a4 
VMware image based provisioning

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
(cherry picked from commit 0f24a56)
@Satellite-QE Satellite-QE mentioned this pull request Aug 2, 2024
Closed
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
@shubhamsg199 @web-flow
Add test for VMware image based provisioning (#15733)
33f08d3 
VMware image based provisioning

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
(cherry picked from commit 0f24a56)
@Satellite-QE Satellite-QE mentioned this pull request Aug 2, 2024
Closed
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
@shubhamsg199 @web-flow
Add test for VMware image based provisioning (#15733)
d93fe8a 
VMware image based provisioning

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
(cherry picked from commit 0f24a56)
@Satellite-QE Satellite-QE mentioned this pull request Aug 2, 2024
Closed
Gauravtalreja1 pushed a commit that referenced this pull request Aug 7, 2024
@shubhamsg199 @Gauravtalreja1
Add test for VMware image based provisioning (#15733)
5f7d43d 
VMware image based provisioning

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
(cherry picked from commit 0f24a56)
Gauravtalreja1 pushed a commit that referenced this pull request Aug 8, 2024
@shubhamsg199 @Gauravtalreja1
Add test for VMware image based provisioning (#15733)
8adb6d8 
VMware image based provisioning

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
(cherry picked from commit 0f24a56)
Gauravtalreja1 pushed a commit that referenced this pull request Sep 11, 2024
@shubhamsg199 @Gauravtalreja1
Add test for VMware image based provisioning (#15733)
e317e73 
VMware image based provisioning

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
(cherry picked from commit 0f24a56)
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shubhamsg199 @jyejare
Add test for VMware image based provisioning (SatelliteQE#15733)
1753e38 
VMware image based provisioning

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synkd synkd synkd approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shubhamsg199 @Satellite-QE @Gauravtalreja1 @ColeHiggins2 @synkd