Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden docker/podman asserts a bit #15779

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Harden docker/podman asserts a bit #15779

merged 1 commit into from
Jul 26, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jul 26, 2024

Problem Statement

We are testing docker/podman search against capsule already but we just check the status, not what is actually returned in stdout. And of course an issue appeared where the search returns nothing but 0 result code. (see bellow)

Solution

Check if the image is returned by the search.
Also check if docker/podman pull actually pulled the image.

Related Issues

https://issues.redhat.com/browse/SAT-25813

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k sync_container_repo_end_to_end

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 26, 2024
@vsedmik vsedmik self-assigned this Jul 26, 2024
@vsedmik vsedmik requested a review from a team as a code owner July 26, 2024 13:25
@vsedmik
Copy link
Contributor Author

vsedmik commented Jul 26, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k sync_container_repo_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7876
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k sync_container_repo_end_to_end --external-logging
Test Result : ========== 1 passed, 23 deselected, 43 warnings in 2528.93s (0:42:08) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 26, 2024
@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jul 26, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 322d94d into SatelliteQE:master Jul 26, 2024
12 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Jul 26, 2024
Closed
@vsedmik vsedmik mentioned this pull request Jul 26, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Harden docker/podman asserts a bit (SatelliteQE#15779)
33576be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @Satellite-QE @Gauravtalreja1 @ColeHiggins2