Solved Arai60/111. Minimum Depth of Binary Tree #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oda
reviewed
Jun 2, 2025
| - 最後にエラー処理を入れているがあまり同じことをしてる人はいなさそうなので不要かもしれない | ||
| - 木構造の高さの測り方として行きがけと帰りがけ・上から配ると下から集めるといった表現をしている人がいた | ||
| - 高さを知りたいだけなら行きがけで良いのかなと感じた | ||
| - あまり帰りがけのメリットが分からなかった |
There was a problem hiding this comment.
高さを知りたいだけならば、行きでよいのは確かです。
もっとも、色々複雑なことをしないといけない場合はあるので、ある程度幅広く選択肢が見えた上で、どうしたいかを選択したほうがいいですね。
変わり種で、こういう書き方もありますよ。(帰りがけをループに直したもの。)
potrue/leetcode#22 (comment)
ryosuketc
reviewed
Jun 2, 2025
| def minDepth(self, root: Optional[TreeNode]) -> int: | ||
| if root is None: | ||
| return 0 | ||
| remaining_nodes_and_depths: List[Tuple[TreeNode, int]] = deque([(root, 1)]) |
There was a problem hiding this comment.
好みだとは思いますが、個人的には nodes_and_depths くらいの長さの変数名でもよいのかなと感じました。比較的コード量が短く処理も簡潔で queue として使っていることがわかりやすいので。
tokuhirat
reviewed
Jun 2, 2025
| def minDepth(self, root: Optional[TreeNode]) -> int: | ||
| if root is None: | ||
| return 0 | ||
| remaining_nodes_and_depths: List[Tuple[TreeNode, int]] = deque([(root, 1)]) |
There was a problem hiding this comment.
右辺を見たら型はわかる、List ではない、の2点で書かなくても良いかなと思いました。型を deque[tuple[TreeNode, int]] のように書くのはNGなのでしょうか？
There was a problem hiding this comment.
こちらの書き方でも問題ないようでした。ご指摘ありがとうございます。
個人的には中に変な型を入れたときに型チェックしてくれると嬉しいのでリストやdequeなどは型を書いておこうと思っています
|
いいとおもいます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題文：https://leetcode.com/problems/minimum-depth-of-binary-tree/description/