Obinna/fix awsbedrock streaming response #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikscale3
previously approved these changes
Jun 4, 2025
karthikscale3
approved these changes
Jun 5, 2025
karthikscale3
added a commit
that referenced
this pull request
Jul 24, 2025
* capture different types of google genai inputs (#534) Co-authored-by: Obinna Okafor <obinna.okafor01@gmail.com> * Read stream before saving attributes. Parse modelId in a more robust way. * Decide based on model name on the set of attributes tracked. * Added basic test for model ID parsing. * Added replay tests for AWS Bedrock. * Added test for streaming requests too. * Obinna/fix awsbedrock streaming response (#538) * fix aws bedrock streaming bug * bump version * add deprecated dependency * restrict current pinecone instrumentation to v6.0.2 * hard code boto3 dependency version * fix duplicate event stream * set test aws key * Fix AWS Bedrock ARN parsing issue in converse methods (#544) * Fix AWS Bedrock ARN parsing issue in converse methods - Replace modelId.split('.') with parse_vendor_and_model_name_from_model_id - Fixes crash when using ARN or cross-region model IDs with multiple dots - Makes patch_converse and patch_converse_stream consistent with other methods Resolves ValueError: too many values to unpack (expected 2) when using: - ARN format: arn:aws:bedrock:us-east-1:<account_id>:inference-profile/us.anthropic.claude-3-haiku-20240307-v1:0 - Cross-region format: us.anthropic.claude-sonnet-4-20250514-v1:0 Co-Authored-By: karthik@scale3labs.com <karthik@scale3labs.com> * Bump version to 3.8.21 for ARN parsing bug fix Co-Authored-By: karthik@scale3labs.com <karthik@scale3labs.com> --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: karthik@scale3labs.com <karthik@scale3labs.com> --------- Co-authored-by: obinnascale3 <109410793+obinnascale3@users.noreply.github.com> Co-authored-by: Obinna Okafor <obinna.okafor01@gmail.com> Co-authored-by: m1kl0sh <miklos.erdelyi@moduscreate.com> Co-authored-by: Obinna Okafor <obinna@scale3labs.com> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: karthik@scale3labs.com <karthik@scale3labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue to help is review the PR better and faster.
Checklist for adding new integration:
APISin constants folder.SERVICE_PROVIDERSin common.pypatch.pyandinstrumentation.pyfiles.all_instrumentationsin langtrace.py and to theInstrumentationTypein types.py files.