Dylan/s3en 2350 aggregate metrics by models v2 #141
Conversation
…1-ability-to-filter-by-user-for-metrics-and-traces
…l-button-to-filter-dialog-v2 Dylan/s3en 2418 add clear all button to filter dialog v2
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 19e2b30 in 2 minutes and 1 seconds
More details
- Looked at
663lines of code in11files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_yIltkDwEbL4Qe17i
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 5 days left in your free trial, upgrade for $20/seat/month or contact us.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c227287 in 1 minute and 43 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_PTtJsrhynAgKQq8M
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 5 days left in your free trial, upgrade for $20/seat/month or contact us.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 04bc99b in 2 minutes and 2 seconds
More details
- Looked at
30lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. lib/services/trace_service.ts:790
- Draft comment:
The PR description mentions the addition of themodelparameter to theGetTokensUsedPerHourPerProjectmethod, but the diff does not show any changes related to this. Please ensure that the implementation is complete and correctly handles themodelparameter. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_JjC3PpwL34Vri6gb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 4 days left in your free trial, upgrade for $20/seat/month or contact us.
Summary:
Enhanced metrics aggregation by introducing model-based filtering in both backend services and frontend components.
Key points:
modelparameter to API endpoints for metrics aggregation.TraceServicemethods inlib/services/trace_service.tsto handlemodelparameter, specifically inGetTokensUsedPerHourPerProjectmethod./api/model-idsfor fetching model IDs.ModelComboboxcomponent for model selection in the UI.modelparameter to API calls.Generated with ❤️ by ellipsis.dev