Fix dns_config on empty cluster. #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
reviewed
Feb 10, 2023
| @@ -17,6 +17,7 @@ | |||
| - 8.8.8.8 | |||
| - 1.0.0.1 | |||
| state: set | |||
| register: result | |||
There was a problem hiding this comment.
Thank you for noticing this :)
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dns_config module didn't work on an empty cluster, so a fix was required.
Also fixed dns config integration tests in 02_dns_config:
register: resultin 1st two tasks, causing tests to failRestoring back to defaultdue to test fail and finding that the restoration is done without this task.