Skip to content

Make use_auth read-only (remove from create/update payload). #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2023
Merged

Make use_auth read-only (remove from create/update payload). #126

merged 4 commits into from
Feb 21, 2023

Conversation

anazobec
Copy link
Collaborator

For the smtp module is better that the use_auth param is read-only, so that was updated.

@anazobec anazobec self-assigned this Feb 21, 2023
@anazobec anazobec requested a review from justinc1 February 21, 2023 11:01
justinc1
justinc1 requested changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current changes looks OK.

Please also remove use_auth in example, integration test, and in tests/integration/integration_config.yml.template.

justinc1
justinc1 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@justinc1 justinc1 merged commit 60b2783 into main Feb 21, 2023
@justinc1 justinc1 deleted the smtp_minor_changes branch February 21, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinc1 justinc1 justinc1 approved these changes

Assignees

@anazobec anazobec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anazobec @justinc1