Skip to content

Conversation

justinc1
Copy link
Collaborator

Ensure time_zone_info is tested with 0 and 1 time zone configured

Test https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4259825907/jobs/7412400599
failed because no timezone was present, and "actual.record.0.timeZone"
tried to get first record from empty list.

Ensure time_server_info is tested with 0 and 1 time server configured

Test
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4259825907/jobs/7412400755
failed because no timeserver was present, and "time_server.record.0.host"
tried to get first record from empty list.

Test https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4259825907/jobs/7412400599
failed because no timezone was present, and "actual.record.0.timeZone"
tried to get first record from empty list.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Test
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4259825907/jobs/7412400755
failed because no timeserver was present, and "time_server.record.0.host"
tried to get first record from empty list.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 requested a review from anazobec February 24, 2023 11:47
@justinc1 justinc1 self-assigned this Feb 24, 2023
Copy link
Collaborator

@anazobec anazobec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@anazobec anazobec merged commit f35e469 into main Feb 24, 2023
@anazobec anazobec deleted the fix-time-zone-and-time-server-integ-tests branch February 24, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants