Skip to content

Conversation

anazobec
Copy link
Collaborator

Fixed a minor issue pointed out in pull request #132.

Info module does not convert SYSLOG_PROTOCOL_UDP to udp, but it should.
The syslog_server_info module should return values that are same as those accepted by syslog_server module.

@anazobec anazobec self-assigned this Feb 24, 2023
@anazobec anazobec requested a review from justinc1 February 24, 2023 12:48
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small changes. i feel a bit bad for being annoying. Hope is not to bad. :)

@anazobec
Copy link
Collaborator Author

anazobec commented Feb 24, 2023

Note: I have to fix unit tests. Missed that.

Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, merging.

@justinc1 justinc1 merged commit b0a967a into main Feb 27, 2023
@justinc1 justinc1 deleted the fix-syslog-server-info-output branch February 27, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants