-
Notifications
You must be signed in to change notification settings - Fork 9
Snapshot cloning #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot cloning #219
Conversation
…ibleCollection into snapshot-clone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes are suggested.
A major change is requirement to clone VM from automated snapshot. This makes things complicated, since automated snapshot have duplicated labels. We can simulate this case by creating two USER snapshots with duplicated label.
Nonunique labels were reason we used source_snapshot_uuid
as snapshot identificator in #179 (sorry, not in main yet). Discussion about how to identify snapshot was long, and there are other alternatives (snapshot serial, label, date as "latest snapshot created before date X" etc). But all those alternatives are more complicated to implement.
By using source_snapshot_uuid
as parameter name we can implement something nicer later, in backward compatible way. I believe vm_snapshot_info
can be used to list snapshosts with specific label, then user can assert in playbook a single snapshot was returned, or can decide which of N snapshots to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is trivial typo in integration test. Atherwise, all good. Ty.
tests/integration/targets/vm_clone/tasks/14_clone_from_snapshot.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/vm_clone/tasks/14_clone_from_snapshot.yml
Outdated
Show resolved
Hide resolved
Added duplicate snapshot label cloning to integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY.
As a user I would like to be able to clone from VM level snapshots using “hypercore” collection.
Testing