Ci for 9.3 #268
Merged
Ci for 9.3 #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
See https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/6334360083/job/17229911477#step:8:62 A guess - we tried to use SnapshotSchedule before it was fully created. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
|
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/6349507160
|
shoriminimoe
approved these changes
Sep 30, 2023
There was a problem hiding this comment.
I'm mixed about adding the sleeps. Would it instead be better to rely on the user (and the tests) to use ansible features like until in their tasks in the event of request failures?
|
The |
ISOs were removed/recreated while some other VMs were using them https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/6347832281/job/17243445064#step:8:113 Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing wait on tasktag for SnapshotSchedule create, and wait on object begin delete for SnapshotSchedule and VirtualDisk.
Other changes are just small CI speedup, and fix how CI test check if HyperCore version >= 9.2.