Skip to content

Conversation

justinc1
Copy link
Collaborator

@justinc1 justinc1 commented Jul 11, 2024

Extend syslog_server module with state=set option. This allows to configure HyperCore to exactly match given Ansible configuration.

The syslog_server module output is extended with records field, as this now makes more sense.

A corner case bug in syslog_server module was also fixed. Before code crashed if we tried to both rename and modify (say change port), and object was already renamed.

@justinc1 justinc1 requested a review from domendobnikar July 11, 2024 17:16
@justinc1 justinc1 self-assigned this Jul 11, 2024
@justinc1 justinc1 force-pushed the syslog-server-set branch 5 times, most recently from e2b213f to f64f978 Compare July 12, 2024 08:40
Copy link
Collaborator

@domendobnikar domendobnikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment otherwise looks good, thank you 👍

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 force-pushed the syslog-server-set branch from f64f978 to 20fccec Compare July 16, 2024 18:54
justinc1 added 2 commits July 16, 2024 21:01
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Module crashed if syslog sever was already renamed, and
it needed to change some other attribute.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 force-pushed the syslog-server-set branch 2 times, most recently from 7fc4bf7 to ce92166 Compare July 16, 2024 19:11
@justinc1 justinc1 merged commit 01cb912 into main Jul 16, 2024
4 checks passed
@justinc1 justinc1 deleted the syslog-server-set branch July 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants