Skip to content

Conversation

domendobnikar
Copy link
Collaborator

@domendobnikar domendobnikar commented Jan 24, 2023

Changed a few things regarding integration tests.

  • Added matrix to CI file (parallel test running now possible with 2 runners).
  • Renamed vm and params test folder to minimize runner downtime.
  • Added ISO preparation job. Now ISO is generated and uploaded before integration testing (duplicated tasks removed or conditioned)
  • Added VM preparation job, now VM is created before integration tests. Can be used in integration tests via cloning. Cloning is a less expensive task than create.

@@ -71,17 +108,19 @@ jobs:
SMB_SHARE: ${{ secrets.SMB_SHARE }}
SMB_USERNAME: ${{ secrets.SMB_USERNAME }}
SMB_PASSWORD: ${{ secrets.SMB_PASSWORD }}
strategy:
matrix:
test_name: ${{ fromJson(needs.integration-prepare-env.outputs.matrix) }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this now, we have two github runners.

@domendobnikar
Copy link
Collaborator Author

domendobnikar commented Jan 24, 2023

Renamed integration/vm folder to integration/a_vm.
Renamed integration/vm_params folder to integration/i_vm_params.
Renamed integration/vm_git_issues folder to integration/git_issues.
This was in order to minimize runner downtime, we want to run longer tests first.
On average we save about 5-7 minutes.

@justinc1
Copy link
Collaborator

Looks ok to me, and tests do pass. merging. thank you

@justinc1 justinc1 merged commit b01ca81 into main Jan 25, 2023
@justinc1 justinc1 deleted the integration-speed-change branch January 25, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants