Skip to content

Conversation

PolonaM
Copy link
Collaborator

@PolonaM PolonaM commented Feb 2, 2023

Added support_tunnel and support_tunnel_info module.

@PolonaM PolonaM self-assigned this Feb 2, 2023
@PolonaM PolonaM marked this pull request as draft February 3, 2023 09:16
@PolonaM PolonaM force-pushed the US03_remote_support_tunnels branch 2 times, most recently from 50a3929 to 9283762 Compare February 6, 2023 10:46
@PolonaM PolonaM marked this pull request as ready for review February 6, 2023 10:47
@PolonaM PolonaM force-pushed the US03_remote_support_tunnels branch from e6058e2 to 094acf0 Compare February 6, 2023 11:21
Copy link
Collaborator

@domendobnikar domendobnikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if we can have multiple tunnels opened at the same time?
If we can, there could be problems with info_module.
Otherwise looks good. 👍

@PolonaM
Copy link
Collaborator Author

PolonaM commented Feb 6, 2023

Do you know if we can have multiple tunnels opened at the same time? If we can, there could be problems with info_module. Otherwise looks good. +1

Thanks for the comment! Only one support tunnel can be opened, so no problems with the info :)

Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. If we treat the code/tunnel_open value as string, things are sort of simpler. We must not know it is number anyway. Simple in sense, return value from support_tunnel is not sometimes int, sometimes false.

returned: success
type: dict
sample:
- tunnel_open: 4422
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not code: 4422? Then you return same name as the input.

returned: success
type: dict
sample:
- tunnel_open: 4422
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: 4422 if you agree.

@PolonaM PolonaM force-pushed the US03_remote_support_tunnels branch from 9558d0c to 4d8366a Compare February 7, 2023 11:36
@justinc1 justinc1 merged commit faea78e into main Feb 7, 2023
@domendobnikar domendobnikar deleted the US03_remote_support_tunnels branch February 7, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants