-
Notifications
You must be signed in to change notification settings - Fork 9
Us03 remote support tunnels #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
50a3929
to
9283762
Compare
e6058e2
to
094acf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if we can have multiple tunnels opened at the same time?
If we can, there could be problems with info_module.
Otherwise looks good. 👍
Thanks for the comment! Only one support tunnel can be opened, so no problems with the info :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. If we treat the code/tunnel_open value as string, things are sort of simpler. We must not know it is number anyway. Simple in sense, return value from support_tunnel is not sometimes int, sometimes false.
plugins/modules/support_tunnel.py
Outdated
returned: success | ||
type: dict | ||
sample: | ||
- tunnel_open: 4422 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not code: 4422
? Then you return same name as the input.
returned: success | ||
type: dict | ||
sample: | ||
- tunnel_open: 4422 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code: 4422
if you agree.
…ations is not allowed
…instead of "tunnel_open"
9558d0c
to
4d8366a
Compare
Added support_tunnel and support_tunnel_info module.