US01 - add type annotation #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolonaM
force-pushed
the
US01_type_annotation
branch
3 times, most recently
from
d188d9f to
6d0a380
Compare
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| minor_changes: | |||
| - Added type annotation to user modules. (https://github.com/ScaleComputing/HyperCoreAnsibleCollection/pull/96) | |||
There was a problem hiding this comment.
This is probably not needed.
Document fragments should be used in case of an "operational/functional" change.
Examples: Bugfix, adding/removing/altering input or output, new module, new functionality. - Something that impacts the final user.
There was a problem hiding this comment.
I agree, I removed the fragment
domendobnikar
approved these changes
Feb 7, 2023
PolonaM
force-pushed
the
US01_type_annotation
branch
from
a4e2f44 to
29a00f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type annotation added to user and user_info module