Skip to content

Registration info #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 10, 2023
Merged

Registration info #98

merged 8 commits into from
Feb 10, 2023

Conversation

domendobnikar
Copy link
Collaborator

@domendobnikar domendobnikar commented Feb 7, 2023 •
edited
Loading

  • Adding missing registration_info
  • Adding documentation fragment for registration and registration info
  • Adding default vars to registration integration test

@domendobnikar domendobnikar marked this pull request as draft February 7, 2023 10:18
@domendobnikar domendobnikar marked this pull request as ready for review February 9, 2023 07:24
@domendobnikar domendobnikar linked an issue Feb 9, 2023 that may be closed by this pull request
Registration info module and doc fragment #90
Closed
@domendobnikar domendobnikar self-assigned this Feb 9, 2023
justinc1
justinc1 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one change for how to revert configuration to correct value after test.
Similar to https://github.com/ScaleComputing/HyperCoreAnsibleCollection/blob/main/tests/integration/targets/smtp/tasks/main.yml:

You can also just merge, and we modify test later.

@justinc1 justinc1 merged commit 1c0f637 into main Feb 10, 2023
@domendobnikar domendobnikar deleted the registration-info branch February 10, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinc1 justinc1 justinc1 approved these changes

Assignees

@domendobnikar domendobnikar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Registration info module and doc fragment
2 participants
@domendobnikar @justinc1